[CALCITE-7353] introduce Milvus adapter with scan and convention support#4925
[CALCITE-7353] introduce Milvus adapter with scan and convention support#4925wg1026688210 wants to merge 1 commit into
Conversation
8439d84 to
53eab9c
Compare
|
CI error: |
53eab9c to
73dbcde
Compare
73dbcde to
88fd7ca
Compare
|
|
@cjj2010 @xuzifu666 @mihaibudiu cc ,the pr is ready |
mihaibudiu
left a comment
There was a problem hiding this comment.
I was expecting to see some kind of README for such a large project, explaining what Milvus is, how it relates to Calcite, and how people can use the adapter. Or perhaps there's some other place for the adapters documentation? But I don't see any.
Thank you for the contribution @wg1026688210 ! As @mihaibudiu mentioned, we can first add some background and value information in Jira. Currently, we support many adapters, and the universality and uniqueness of adapters are important reference indicators for introducing adapters. |
|
|
Thank you for the contribution @wg1026688210 ! Although I don't know much about Milvus, I think this adapter is very valuable. As @zabetak stated in CALCITE-6908, the test coverage of the milvus adaptor should ideally reach 80%. I suggest including test cases along with the feature descriptions and adding the test cases mentioned in the descriptions to the code. This will make it easier for reviewers to review the code. |



Add the foundational Milvus adapter module to Apache Calcite:
This is the minimal skeleton; Filter/Project/VectorSearch rules are intentionally omitted for subsequent PRs.