Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion packages/opencode/src/tool/task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,30 @@ function errorText(error: unknown) {
return String(error)
}

function taskResultError(error: MessageV2.Assistant["error"]) {
if (!error) return "none"
return JSON.stringify(error) ?? String(error)
}

function taskResultText(result: MessageV2.WithParts) {
const textPart = result.parts.findLast((item) => item.type === "text")
if (textPart) return textPart.text

const partTypes = result.parts.map((item) => item.type).join(", ") || "none"
if (result.info.role !== "assistant") {
return ["Subagent completed without an assistant response.", `role: ${result.info.role}`, `parts: ${partTypes}`].join(
"\n",
)
}

return [
"Subagent completed without a text response.",
`finish: ${result.info.finish ?? "unknown"}`,
`error: ${taskResultError(result.info.error)}`,
`parts: ${partTypes}`,
].join("\n")
}

export const TaskTool = Tool.define(
id,
Effect.gen(function* () {
Expand Down Expand Up @@ -208,7 +232,7 @@ export const TaskTool = Tool.define(
},
parts,
})
return result.parts.findLast((item) => item.type === "text")?.text ?? ""
return taskResultText(result)
})

const resumeWhenIdle: (input: { userID: MessageID; state: "completed" | "error" }) => Effect.Effect<void> =
Expand Down
125 changes: 125 additions & 0 deletions packages/opencode/test/tool/task.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,44 @@ function reply(input: SessionPrompt.PromptInput, text: string): MessageV2.WithPa
}
}

type PartDraft = MessageV2.Part extends infer Part
? Part extends MessageV2.Part
? Omit<Part, "id" | "messageID" | "sessionID">
: never
: never

function replyWithParts(
input: SessionPrompt.PromptInput,
parts: PartDraft[],
info?: Partial<MessageV2.Assistant>,
): MessageV2.WithParts {
const id = MessageID.ascending()
return {
info: {
id,
role: "assistant",
parentID: input.messageID ?? MessageID.ascending(),
sessionID: input.sessionID,
mode: input.agent ?? "general",
agent: input.agent ?? "general",
cost: 0,
path: { cwd: "/tmp", root: "/tmp" },
tokens: { input: 0, output: 0, reasoning: 0, cache: { read: 0, write: 0 } },
modelID: input.model?.modelID ?? ref.modelID,
providerID: input.model?.providerID ?? ref.providerID,
time: { created: Date.now() },
finish: "stop",
...info,
},
parts: parts.map((part) => ({
...part,
id: PartID.ascending(),
messageID: id,
sessionID: input.sessionID,
})) as MessageV2.Part[],
}
}

describe("tool.task", () => {
it.instance(
"description sorts subagents by name and is stable across calls",
Expand Down Expand Up @@ -242,6 +280,93 @@ describe("tool.task", () => {
}),
)

it.instance("execute returns child text output when present", () =>
Effect.gen(function* () {
const { chat, assistant } = yield* seed()
const tool = yield* TaskTool
const def = yield* tool.init()

const result = yield* def.execute(
{
description: "inspect bug",
prompt: "look into the cache key path",
subagent_type: "general",
},
{
sessionID: chat.id,
messageID: assistant.id,
agent: "build",
abort: new AbortController().signal,
extra: { promptOps: stubOps({ text: "done" }) },
messages: [],
metadata: () => Effect.void,
ask: () => Effect.void,
},
)

expect(result.output).toContain("<task_result>\ndone\n</task_result>")
}),
)

it.instance("execute returns diagnostic output when child finishes without a text part", () =>
Effect.gen(function* () {
const { chat, assistant } = yield* seed()
const tool = yield* TaskTool
const def = yield* tool.init()
const promptOps: TaskPromptOps = {
cancel: () => Effect.void,
resolvePromptParts: (template) => Effect.succeed([{ type: "text" as const, text: template }]),
prompt: (input) =>
Effect.succeed(
replyWithParts(
input,
[
{
type: "step-start",
},
{
type: "reasoning",
text: "thinking",
time: { start: Date.now() },
},
{
type: "step-finish",
reason: "stop",
cost: 0,
tokens: { input: 0, output: 0, reasoning: 0, cache: { read: 0, write: 0 } },
},
],
{ finish: "stop" },
),
),
loop: (input) => Effect.succeed(reply({ sessionID: input.sessionID, parts: [] }, "done")),
}

const result = yield* def.execute(
{
description: "inspect bug",
prompt: "look into the cache key path",
subagent_type: "general",
},
{
sessionID: chat.id,
messageID: assistant.id,
agent: "build",
abort: new AbortController().signal,
extra: { promptOps },
messages: [],
metadata: () => Effect.void,
ask: () => Effect.void,
},
)

expect(result.output).toContain("Subagent completed without a text response.")
expect(result.output).toContain("finish: stop")
expect(result.output).toContain("error: none")
expect(result.output).toContain("parts: step-start, reasoning, step-finish")
}),
)

it.instance("execute asks by default and skips checks when bypassed", () =>
Effect.gen(function* () {
const { chat, assistant } = yield* seed()
Expand Down
Loading