Skip to content

fix(task): surface non-text subagent results#29176

Open
smithyyang wants to merge 1 commit into
anomalyco:devfrom
smithyyang:fix-task-empty-subagent-result
Open

fix(task): surface non-text subagent results#29176
smithyyang wants to merge 1 commit into
anomalyco:devfrom
smithyyang:fix-task-empty-subagent-result

Conversation

@smithyyang
Copy link
Copy Markdown

@smithyyang smithyyang commented May 25, 2026

Issue for this PR

Closes #24447

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This fixes the task tool returning an empty <task_result> when a subagent completes without a final text part.

Before this change, TaskTool only looked for the last text part and fell back to "" if none existed. That made reasoning-only or non-text child completions look like blank results in the parent session.

This change keeps the existing behavior when a child returns text, and otherwise returns a short diagnostic summary with the finish reason, error, and emitted part types.

How did you verify your code works?

  • Ran bun run typecheck in packages/opencode
  • Ran bun test test/tool/task.test.ts --test-name-pattern "execute returns child text output when present|execute returns diagnostic output when child finishes without a text part"
  • Ran bun test test/cli/run/entry.body.test.ts test/cli/run/scrollback.surface.test.ts

Screenshots / recordings

Not a UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. and removed needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels May 25, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TaskTool returns no diagnostic context when subagent result text is empty or missing

1 participant