Stop rendering contacts in Whitehall (WHIT-2390)#10583
Draft
ChrisBAshton wants to merge 4 commits intomainfrom
Draft
Stop rendering contacts in Whitehall (WHIT-2390)#10583ChrisBAshton wants to merge 4 commits intomainfrom
ChrisBAshton wants to merge 4 commits intomainfrom
Conversation
ChrisBAshton
changed the title
We want to move rendering of contacts into Publishing API.
TODO: roll this out across all document types.
This is what Publishing API will use to render the embed. Publishing API has no concept of the integer IDs we use within Whitehall (i.e. [Contact:123]).
ChrisBAshton
force-pushed
the
do-not-render-contacts
branch
from
4fe7a08 to
47abb4e
Compare
ChrisBAshton
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to move rendering of contacts into Publishing API.
Sister PR: alphagov/publishing-api#3543
JIRA: https://gov-uk.atlassian.net/browse/WHIT-2390
This application is owned by the Whitehall Experience team. Please let us know in #govuk-whitehall-experience-tech when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.