Draft
Conversation
We want to receive GovSpeak so that we can do the Contact rendering in Publishing API, rather than rely on Whitehall to do it.
- The contact 'expanded link' is now being sent to Publishing API from Whitehall - Publishing API will (via GovSpeak) render the embedded Contact provided a `contacts` array is passed to the `Govspeak::Document` call as per https://github.com/alphagov/govspeak/blob/015d1e37580d51ca17cc708f35bbde8b197a1142/test/govspeak_contacts_test.rb#L98 - We've successfully tested rendering a hardcoded Contact link (commented out in this commit), and now need to figure out how to fetch the Contact dynamically instead. Testing locally with: ``` presenter = Presenters::EditionPresenter.new(Document.find_by(content_id: "14eeda85-67bb-48d5-a93d-f4ac8dd173ef").editions.last) presenter.present ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sister PR: alphagov/whitehall#10583
JIRA: https://gov-uk.atlassian.net/browse/WHIT-2390
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.