DRAFT: Deferred index creation (comments-based) - do not merge#374

Draft

michal-morzywolek wants to merge 90 commits intomainfrom

experimental/deferred-index-comments

Commits on Feb 4, 2026

Add comprehensive test suite for UpgradeGraph class

Your Name
and
claude
committed

Commits on Feb 20, 2026

Add DeferredIndexConfig with defaults for deferred index execution

Your Name
and
claude
committed
Add DeferredIndexOperation system tables and bootstrap upgrade step

Your Name
and
claude
committed

Commits on Feb 21, 2026

Add DeferredIndexOperation domain class, enums, and DAO

Your Name
and
claude
committed
Add DeferredAddIndex SchemaChange with visitor wiring and DAO interface split

Your Name
and
claude
committed

Commits on Feb 22, 2026

Add SchemaEditor.addIndexDeferred() and visitor wiring for Stage 5

Your Name
and
claude
committed

Commits on Feb 28, 2026

Add auto-cancel and dependency tracking for deferred index operations

Your Name
and
claude
committed

Commits on Mar 1, 2026

Add DeferredIndexExecutor, RecoveryService, and Validator (Stages 7-10)

Your Name
and
claude
committed

Commits on Mar 2, 2026

Add cross-platform deferred index dialect support (Stage 11)

Your Name
and
claude
committed
Add end-to-end integration tests for deferred index lifecycle (Stage 12)

Your Name
and
claude
committed
Fix review findings: timestamp format, boolean column, and ChangeIndex/RenameIndex deferred handling

Your Name
and
claude
committed
Cap retry backoff delay and fail upgrade on unresolved deferred indexes

Your Name
and
claude
committed
Fix review findings #4, #5, #7: backoff cap, validator throw, in-memory tracking

Your Name
and
claude
committed

Commits on Mar 3, 2026

Use BIG_INTEGER primary keys for both deferred index tables

Your Name
and
claude
committed
Replace N+1 queries with JOIN in DeferredIndexOperationDAO

Your Name
and
claude
committed
Fix case-sensitivity inconsistencies in deferred index handling

Your Name
and
claude
committed
Widen deferred index table name columns to SchemaValidator.MAX_LENGTH

Your Name
and
claude
committed
Remove dead code and fix stale comment

Your Name
and
claude
committed
Remove @ImplementedBy and @Inject from DAO since it is always constructed directly

Your Name
and
claude
committed
Distinguish deferred index in human-readable upgrade output

Your Name
and
claude
committed
Add config validation to deferred index services

Your Name
and
claude
committed
Add DeferredIndexService facade and make internal classes package-private

Your Name
and
claude
committed
Fix stale assertions in TestUpgradeSteps for deferred index tables

Your Name
and
claude
committed
Add unit tests to fill coverage gaps in deferred index feature

Your Name
and
claude
committed
Improve test coverage for deferred index feature

Your Name
and
claude
committed
Refactor deferred index services to use Guice constructor injection

Your Name
and
claude
committed
Add force-immediate config to bypass deferred index creation

Your Name
and
claude
committed
Add force-deferred config to override immediate index creation

Your Name
and
claude
committed
Add coverage for forceImmediateIndexes and forceDeferredIndexes getters

Your Name
and
claude
committed
Merge origin/main into experimental/deferred-index-creation

Your Name
and
claude
committed
Fix review findings: stale rename, negative IDs, SKIPPED status, javadoc

Your Name
and
claude
committed
Add DEBUG logging to deferred index services

Your Name
and
claude
committed
Code review fixes: remove dead code, simplify timestamps, decouple DAO

Your Name
and
claude
committed
Refactor DeferredIndexChangeServiceImpl: extract SQL builders, add javadoc

Your Name
and
claude
committed
Rename operationTimeoutSeconds to executionTimeoutSeconds, default 8h

Your Name
and
claude
committed

Commits on Mar 4, 2026

Extract interfaces for DeferredIndexExecutor, DeferredIndexRecoveryService, DeferredIndexValidator

Your Name
and
claude
committed
Extract ExecutionResult/ExecutionStatus from DeferredIndexExecutor, remove getStatus

Your Name
and
claude
committed
Replace polling with CompletableFuture, validate config in execute()

Your Name
and
claude
committed
Ensure deferred index tables exist before parallel upgrade steps

Your Name
and
claude
committed
Rename DeferredIndexValidator to DeferredIndexReadinessCheck, wire into upgrade

Your Name
and
claude
committed
Add DeferredIndexExecutorServiceFactory for pluggable thread pool creation

Your Name
and
claude
committed
Remove test-only constructor from DeferredIndexExecutorImpl

Your Name
and
claude
committed

Commits on Mar 5, 2026

Replace ScheduledExecutorService with per-operation progress logging
Your Name
committed
Add getProgress() to DeferredIndexService facade
Your Name
committed
Executor cleanup: INFO/ERROR logging with elapsed time, autocommit restore, remove truncate
Your Name
committed
Add Javadoc to all non-public methods across deferred index package
Your Name
committed
Code review fixes: remove dead DAO methods, drop operationType column, inject SqlScriptExecutorProvider

Your Name
and
claude
committed
Remove shutdown() from DeferredIndexExecutor interface

Your Name
and
claude
committed
Add TDD integration tests for deferred index lifecycle (expect compile failures)

Your Name
and
claude
committed
Rename DeferredIndexConfig to DeferredIndexExecutionConfig, add forceDeferredIndexBuildOnRestart

Your Name
and
claude
committed
Fix Mode 1: move readiness check before sourceSchema capture, add schema augmentation for Mode 2

Your Name
and
claude
committed
Executor crash recovery + remove recovery service from DeferredIndexServiceImpl

Your Name
and
claude
committed
Remove recovery service, dead DAO method, fix lifecycle test index validation

Your Name
and
claude
committed
Code review fixes: dedup reconstructIndex, remove dead DAO methods, add augment tests

Your Name
and
claude
committed

Commits on Mar 6, 2026

Remove redundant fields from executor, remove dead DAO insertOperation method

Your Name
and
claude
committed
Simplify resetAllInProgressToPending, remove noOp(), fix javadoc wording

Your Name
and
claude
committed
Rename run/augment methods, extract awaitCompletion, add stale-index log

Your Name
and
claude
committed

Commits on Mar 9, 2026

Fix DeferredIndexReadinessCheck Javadoc to describe both modes

Your Name
and
claude
committed
Code review fixes: inline upgrade tables, re-defer on ChangeIndex, remove guard

Your Name
and
claude
committed
Remove unnecessary volatile from executionFuture field

Your Name
and
claude
committed

Commits on Mar 18, 2026

Code review fixes: harden executor, DAO, config validation, fix flaky tests

Your Name
and
claude
committed

Commits on Mar 19, 2026

Remove Mode 1/Mode 2, simplify to unified deferred index behavior

Your Name
and
claude
committed
Add @see Javadoc to all @Override methods, split POJO test into per-field tests

Your Name
and
claude
committed
Remove plan files from repo, add PLAN-*.md to .gitignore

Your Name
and
claude
committed
Add CLAUDE.md to .gitignore

Your Name
and
claude
committed
Fix stray characters in readiness check Javadoc

Your Name
and
claude
committed
Add dialect-level deferred index support, fall back to immediate on unsupported platforms

Your Name
and
claude
committed

Commits on Mar 20, 2026

Add supportsDeferredIndexCreation() override to H2v2 dialect, fix changeIndex test

Your Name
and
claude
committed

Commits on Mar 24, 2026

Remove DeferredIndexOperationColumn table, store columns as comma-separated string

Your Name
and
claude
committed
Move deferred index config into UpgradeConfigAndContext, validate at point of use

Your Name
and
claude
committed
Add deferredIndexCreationEnabled kill switch, disabled by default

Your Name
and
claude
committed
Fix SonarCloud code smells: extract constants, clean up imports, refactor loop

Your Name
and
claude
committed
Code review fixes: constants, Javadoc, private visibility, redundant UPDATE

Your Name
and
claude
committed

Commits on Apr 1, 2026

Add isDeferred() property to Index model

Your Name
and
claude
committed
Add deferred index comment parsing utilities and SqlDialect hook

Your Name
and
claude
committed
Add IF EXISTS variants for index drop and rename DDL

Your Name
and
claude
committed
Add deferred index comment support to all dialect MetaDataProviders

Your Name
and
claude
committed

Commits on Apr 2, 2026

Remove addIndexDeferred API, handle deferral via index.isDeferred() flag

Your Name
and
claude
committed
Rewrite executor to scan comments, remove tracking table infrastructure

Your Name
and
claude
committed
Add documentation for comments-based deferred index model

Your Name
and
claude
committed
Fix integration tests for comments-based model, remove stale references

Your Name
and
claude
committed
Remove unused assertIndexDoesNotExist helpers and stale imports

Your Name
and
claude
committed
Add integration tests for remove/change/rename on deferred indexes

Your Name
and
claude
committed
Update documentation with MetaDataProvider merge behavior and test coverage

Your Name
and
claude
committed
Add post-failure index-exists check to executor, update JIRA description

Your Name
and
claude
committed
Add targeted comment scan and PostgreSQL invalid index detection

Your Name
and
claude
committed

Commits on Apr 3, 2026

Code review fixes: DDL refactor, schema sync bugs, test improvements

Your Name
and
claude
committed
Remove dead DeferredIndexReadinessCheck (no-op in comments-based model)

Your Name
and
claude
committed

Commits on Apr 4, 2026

Extract buildPostgreSqlCreateIndex to eliminate DDL duplication

Your Name
and
claude
committed

Commits on Apr 5, 2026

Add given/when/then structure to all deferred index tests

Your Name
and
claude
committed