Skip to content

DRAFT: Deferred index creation (comments-based) - do not merge #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
michal-morzywolek wants to merge 90 commits into
base: main
Choose a base branch
from

Add given/when/then structure to all deferred index tests

9bdbae3
Select commit
Loading
Failed to load commit list.
Draft

DRAFT: Deferred index creation (comments-based) - do not merge #374

Add given/when/then structure to all deferred index tests
9bdbae3
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 5, 2026 in 1m 58s

Quality Gate passed

Issues
9 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.0% Coverage on New Code
1.6% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 403 in morf-oracle/src/main/java/org/alfasoftware/morf/jdbc/oracle/OracleDialect.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal " IS '" 3 times. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ1Vb9dW8MsCUjGK0urP&open=AZ1Vb9dW8MsCUjGK0urP&pullRequest=374

Check warning on line 237 in morf-core/src/main/java/org/alfasoftware/morf/upgrade/SchemaChangeSequence.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "upgradeUUID" private field. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ1Vb9WW8MsCUjGK0urL&open=AZ1Vb9WW8MsCUjGK0urL&pullRequest=374

Check failure on line 198 in morf-core/src/main/java/org/alfasoftware/morf/upgrade/deferred/DeferredIndexExecutorImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "] on table [" 8 times. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ1Vb9Vm8MsCUjGK0urH&open=AZ1Vb9Vm8MsCUjGK0urH&pullRequest=374

Check warning on line 118 in morf-core/src/test/java/org/alfasoftware/morf/upgrade/deferred/TestDeferredIndexExecutorUnit.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the declaration of thrown exception 'java.sql.SQLException', as it cannot be thrown from method's body. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ1Vb9YL8MsCUjGK0urN&open=AZ1Vb9YL8MsCUjGK0urN&pullRequest=374

Check failure on line 279 in morf-core/src/main/java/org/alfasoftware/morf/upgrade/deferred/DeferredIndexExecutorImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "Deferred index [" 4 times. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ1Vb9Vm8MsCUjGK0urI&open=AZ1Vb9Vm8MsCUjGK0urI&pullRequest=374

Check failure on line 124 in morf-core/src/main/java/org/alfasoftware/morf/upgrade/RenameIndex.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ1Vb9WB8MsCUjGK0urJ&open=AZ1Vb9WB8MsCUjGK0urJ&pullRequest=374

Check warning on line 52 in morf-core/src/main/java/org/alfasoftware/morf/upgrade/SchemaChangeSequence.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "log" private field. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ1Vb9WW8MsCUjGK0urK&open=AZ1Vb9WW8MsCUjGK0urK&pullRequest=374

Check warning on line 27 in morf-postgresql/src/main/java/org/alfasoftware/morf/jdbc/postgresql/PostgreSQLMetaDataProvider.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import 'org.alfasoftware.morf.metadata.Column'. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ1Vb9ZC8MsCUjGK0urO&open=AZ1Vb9ZC8MsCUjGK0urO&pullRequest=374

Check failure on line 311 in morf-core/src/main/java/org/alfasoftware/morf/jdbc/SqlDialect.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal " RENAME TO " 3 times. 

See more on https://sonarcloud.io/project/issues?id=org.alfasoftware%3Amorf-parent&issues=AZ1Vb9Xa8MsCUjGK0urM&open=AZ1Vb9Xa8MsCUjGK0urM&pullRequest=374
View more details on SonarQubeCloud