Potential fix for code scanning alert no. 4: URL redirection from remote source#395
Draft
Joe-Heffer-Shef wants to merge 1 commit intomainfrom
Draft
Potential fix for code scanning alert no. 4: URL redirection from remote source#395Joe-Heffer-Shef wants to merge 1 commit intomainfrom
Joe-Heffer-Shef wants to merge 1 commit intomainfrom
Conversation
…ote source Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/RSE-Sheffield/SORT/security/code-scanning/4
To fix this issue, we need to validate the value of
request.META["HTTP_REFERER"]before using it as the redirect target. The best way to do this in Django is to use the built-in utility functiondjango.utils.http.url_has_allowed_host_and_scheme, which determines whether the URL is safe for redirection (i.e., it uses an allowed host and scheme). We should replace the current usage so that if the REFERER is allowed, we redirect to it; otherwise, we should redirect to a safe default such as the survey improvement plan page (as currently coded).Required changes:
url_has_allowed_host_and_schemefromdjango.utils.http, if not already imported.redirectlogic inSurveyImprovementPlanUpdateView.postso that before redirecting to the REFERER, we check if it is allowed using the function above.Suggested fixes powered by Copilot Autofix. Review carefully before merging.