Skip to content

feat(code): unified PR creation workflow#1377

Merged
jonathanlab merged 1 commit intomainfrom
03-30-feat_code_unified_pr_creation_workflow
Apr 1, 2026
Merged

feat(code): unified PR creation workflow#1377
jonathanlab merged 1 commit intomainfrom
03-30-feat_code_unified_pr_creation_workflow

Conversation

@adboio
Copy link
Copy Markdown
Contributor

@adboio adboio commented Mar 30, 2026

Problem

the current method for getting changes shipped takes a lot of clicks, and at least 3 separate modals -- create branch, commit, create PR.

for what i expect to be the more general case ("agent did work, i wanna ship it"), we can simplify this

removed

  • existing "commit and create PR" flow from the commit dialog
  • existing standalone "create pr" action / dialog

added

introduces a new unified "create PR" workflow that does these steps, as needed:

  1. create & checkout new branch
  2. commit
  3. push
  4. create PR
full input - on default branch, changes to be committed loading states error state
Screenshot 2026-03-31 at 9.27.33 AM.png
Screenshot 2026-03-31 at 9.27.47 AM.png
Screenshot 2026-03-31 at 9.27.52 AM.png

create pr flow notes:

  • if the user is already on a non-default branch, the first step is optional
  • if the user has no uncommitted changes, the flow starts on step 3
  • if a PR already exists on the current branch and there are new uncommited changes, the flow creates a new branch (stack time baby)
  • AI generation is delayed til the user clicks "create" - happens if the commit msg and/or pr details are left empty
  • primary CTA swaps to "view PR" when a PR exists, until new changes appear, then it swaps back to "create PR"
  • all existing individual actions are still available in the dropdown

How did you test this?

i have not yet tested this in cloud or worktrees

manually tested, i know it's a big PR, so would appreciate others manually testing a bit too 💪

Copy link
Copy Markdown
Contributor Author

adboio commented Mar 30, 2026

@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch 5 times, most recently from e694de0 to 6950f57 Compare March 31, 2026 00:54
@adboio adboio marked this pull request as ready for review March 31, 2026 00:54
@adboio adboio requested a review from a team March 31, 2026 00:54
@jonathanlab jonathanlab removed the request for review from a team March 31, 2026 07:48
@adboio adboio requested a review from a team March 31, 2026 14:49
@adboio adboio marked this pull request as draft March 31, 2026 14:52
@adboio adboio removed the request for review from a team March 31, 2026 14:53
@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch 4 times, most recently from b86f01b to 57fbfd1 Compare March 31, 2026 17:49
@adboio adboio changed the base branch from main to graphite-base/1377 March 31, 2026 17:53
@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch from 57fbfd1 to 0416434 Compare March 31, 2026 17:53
@adboio adboio changed the base branch from graphite-base/1377 to fix/diff-scan-limit March 31, 2026 17:53
@adboio adboio changed the base branch from fix/diff-scan-limit to graphite-base/1377 March 31, 2026 17:56
@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch from 0416434 to a31524d Compare March 31, 2026 17:56
@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch from a31524d to 131038b Compare March 31, 2026 18:02
@adboio adboio force-pushed the graphite-base/1377 branch from 366af61 to 12fe24e Compare March 31, 2026 18:02
@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch from 131038b to a9d34cd Compare March 31, 2026 18:13
@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch from a9d34cd to 3a776c3 Compare March 31, 2026 18:16
@adboio adboio force-pushed the graphite-base/1377 branch from a27b8da to 03f27e5 Compare March 31, 2026 18:16
@adboio adboio changed the base branch from graphite-base/1377 to 03-31-send_full_diff_to_pr_title_body_generator March 31, 2026 18:16
@adboio adboio requested a review from a team March 31, 2026 19:33
@adboio adboio marked this pull request as ready for review March 31, 2026 19:33
charlesvien
charlesvien previously approved these changes Mar 31, 2026
@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch from 9e220cd to 4f07e7f Compare March 31, 2026 21:33
@adboio adboio force-pushed the 03-31-send_full_diff_to_pr_title_body_generator branch from 86ef9fd to 479b56d Compare March 31, 2026 21:33
@adboio adboio mentioned this pull request Mar 31, 2026
@adboio adboio force-pushed the 03-31-send_full_diff_to_pr_title_body_generator branch 2 times, most recently from 2ae8173 to e4eebfb Compare March 31, 2026 22:15
@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch 2 times, most recently from 87bd942 to 01efafa Compare April 1, 2026 02:18
@adboio adboio changed the base branch from 03-31-send_full_diff_to_pr_title_body_generator to graphite-base/1377 April 1, 2026 07:08
@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch from 01efafa to c723cc5 Compare April 1, 2026 07:08
@adboio adboio force-pushed the graphite-base/1377 branch from e4eebfb to 56aba1c Compare April 1, 2026 07:08
@graphite-app graphite-app bot changed the base branch from graphite-base/1377 to main April 1, 2026 07:08
@graphite-app graphite-app bot dismissed charlesvien’s stale review April 1, 2026 07:08

The base branch was changed.

@adboio adboio force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch from c723cc5 to c91debf Compare April 1, 2026 07:08
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Apr 1, 2026

Merge activity

  • Apr 1, 10:19 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Apr 1, 10:19 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Apr 1, 10:51 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 1, 10:52 AM UTC: @jonathanlab merged this pull request with Graphite.

Copy link
Copy Markdown
Contributor

@jonathanlab jonathanlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love that you created some stories as well

@jonathanlab jonathanlab force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch from c91debf to c010a92 Compare April 1, 2026 10:28
@jonathanlab jonathanlab force-pushed the 03-30-feat_code_unified_pr_creation_workflow branch from c010a92 to bfeebce Compare April 1, 2026 10:36
@jonathanlab jonathanlab merged commit 67e4f9f into main Apr 1, 2026
16 checks passed
@jonathanlab jonathanlab deleted the 03-30-feat_code_unified_pr_creation_workflow branch April 1, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants