feat(code): replace in-chat diffs with pierre/diffs#1414
Merged
jonathanlab merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
This was referenced Apr 1, 2026
Contributor
Author
This was referenced Apr 1, 2026
This was referenced Apr 1, 2026
adboio
force-pushed
the
03-31-feat_code_new_diff_review_panel
branch
from
82153f2 to
1ce1ac4
Compare
adboio
force-pushed
the
03-31-feat_code_replace_in-chat_diffs_with_pierre_diffs
branch
from
2b4b7a1 to
873c4d1
Compare
jonathanlab
approved these changes
Apr 1, 2026
jonathanlab
force-pushed
the
03-31-feat_code_replace_in-chat_diffs_with_pierre_diffs
branch
from
873c4d1 to
5c36ec0
Compare
jonathanlab
force-pushed
the
03-31-feat_code_new_diff_review_panel
branch
from
1ce1ac4 to
39f63f8
Compare
jonathanlab
force-pushed
the
03-31-feat_code_replace_in-chat_diffs_with_pierre_diffs
branch
from
5c36ec0 to
c1a60a4
Compare
jonathanlab
force-pushed
the
03-31-feat_code_new_diff_review_panel
branch
from
39f63f8 to
2beccd1
Compare
Contributor
Merge activity
|
jonathanlab
changed the base branch from
03-31-feat_code_new_diff_review_panel
to
graphite-base/1414
jonathanlab
pushed a commit
that referenced
this pull request
Apr 1, 2026
## Problem - current diff viewing experience is rough - we have a ton of cloud vs. local branching logic that shouldn't _really_ be necessary <!-- Who is this for and what problem does it solve? --> <!-- Closes #ISSUE_ID --> ## Changes | review panel | split view | deferred rendering | | --- | --- | --- | | <br><br> | <br> | <br><br><br> | | | | | - adds a new "review" panel that renders all diffs in one scrollable view - swaps codemirror for `@pierre/diffs` ([diffs.com](https://diffs.com/)) - shadow dom rendering w/ [web workers](https://diffs.com/docs#worker-pool) 🤓 - defers large diffs (generated, deleted, just big) - removes a ton of codemirror stuff that is no longer needed - sorta-kinda-almost unifies the rendering for cloud and local diffs - local and cloud have seperate diff views, but both share as much as possible via `ReviewShell` - removed the separate `diff` and `cloud-diff` panel types/logic, uses a single `review` tab now ## next - this is pretty fast because we're using web workers and only making a single git query to get the initial diff content for all files. HOWEVER it could be FASTER... i want to use [diffs' built-in virtualization](https://diffs.com/docs#virtualization), but could not get it to work yet, so i'll follow up on that - [#1414] will probably swap the in-chat diff for this new view, then we will only need codemirror for full file viewing (and hopefully editing at some point...) - i asked the pierre team and they are planning to make diffs editable to some extent... 👀 - adding a "comment" button per line in the diff that allows you to "ask for followups" w/ that file ref <!-- What did you change and why? --> <!-- If there are frontend changes, include screenshots. --> ## How did you test this? manually, a bunch <!-- Describe what you tested -- manual steps, automated tests, or both. --> <!-- If you're an agent, only list tests you actually ran. -->
<br><br){kind=link}
<br){kind=link}
<br><br><br){kind=link}
jonathanlab
force-pushed
the
03-31-feat_code_replace_in-chat_diffs_with_pierre_diffs
branch
from
c1a60a4 to
75d4dcd
Compare
jonathanlab
deleted the
03-31-feat_code_replace_in-chat_diffs_with_pierre_diffs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
as part of #1410, i replaced codemirror with
@pierre/diffsin the changed file diff viewsbut the in-chat diffs still use codemirror
Changes
for consistency mostly, replacing the in-chat diff view with the same thing, and some related cleanup
How did you test this?
manually