Conversation
… pings - Use Settings.region as CloudMatch streaming base URL when set (was unused). - Add Connection settings: WebRTC ICE transport policy (all vs relay-only). - Region latency probe: 5 TCP samples with min/max/jitter; show jitter in UI. - Clarify that region choice optimizes data center routing, not a VPN booster. Co-authored-by: Zortos <zortosdev@proton.me>
…on section Co-authored-by: Zortos <zortosdev@proton.me>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| const preferred = settings.region?.trim() ?? ""; | ||
| if (preferred && preferred.startsWith("https://")) { | ||
| return preferred.endsWith("/") ? preferred : `${preferred}/`; | ||
| } |
There was a problem hiding this comment.
Stale region URLs override valid provider endpoint
Medium Severity
effectiveStreamingBaseUrl accepts any saved settings.region that starts with https:// without checking it exists in current regions. A stale or cross-provider region URL now overrides selectedProvider.streamingServiceUrl, so CloudMatch calls can be routed to an invalid endpoint and session/game actions fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses OPEN-7 (ExitLag-style “route optimization”) with what we can do inside an open GFN client: no proprietary VPN mesh, but clearer data-center routing, optional WebRTC relay-only for tricky networks, and better region latency probes (avg + jitter + min/max).
Changes
https://…base URL is used as the CloudMatch/streaming base URL instead of only the login provider default (the setting was previously unused for API calls).DefaultvsRelay onlymaps toRTCPeerConnectioniceTransportPolicy(allvsrelay). Relay-only can help when only TURN works (VPN / strict NAT); it may add latency.npm run typecheckpasses.Linear Issue: OPEN-7