Conversation
…er regio…" This reverts commit b6d25fc.
|
Issue reopened: OPEN-7 try to add a thing like exitlag lagofast |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| return base; | ||
| }, [selectedProvider, settings.region]); | ||
| return selectedProvider?.streamingServiceUrl ?? ""; | ||
| }, [selectedProvider]); |
There was a problem hiding this comment.
Region selection no longer affects routing
Medium Severity
effectiveStreamingBaseUrl now always uses selectedProvider.streamingServiceUrl and ignores settings.region. The Region picker in SettingsPage.tsx still lets users choose specific regions, but that value is no longer applied when calling streaming APIs, so manual region selection silently has no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reverts #174
Note
Medium Risk
Touches WebRTC connection configuration and region selection/ping behavior, which can affect stream connectivity and latency. Changes are mostly removal/simplification, but regressions are possible for users relying on relay-only ICE or detailed ping diagnostics.
Overview
Reverts the prior route/latency tools work by removing
iceTransportPolicyfrom shared settings/types, the renderer settings UI, and theGfnWebRtcClientRTCPeerConnectionconfiguration.Simplifies region latency probing: main process
PING_REGIONSnow runs 3 TCP connect samples and returns only an averagedpingMs(dropping min/max/jitter/sample metadata), and the settings page ping cache/UI is updated accordingly (including removing jitter display).Also simplifies streaming base URL derivation to always use the selected provider’s
streamingServiceUrl, and updatespackage-lock.jsonmetadata/version fields.Written by Cursor Bugbot for commit 9c30b5c. This will update automatically on new commits. Configure here.