pyinotify: patch for python 3.12 support#325685
Merged
Merged
Conversation
asyncore was removed from the python 3.12 standard library: https://peps.python.org/pep-0594/ This patch was original sourced from: seb-m/pyinotify#205
42fdb8d to
7ea81e0
Compare
|
Is this ready to merge? |
marcusramberg
approved these changes
Jul 15, 2024
Contributor
marcusramberg
left a comment
There was a problem hiding this comment.
I checked out this PR and tested that it fixes ulauncher which is currently broken in master due to pyinotify. lgtm
Contributor
|
Successfully created backport PR for |
1 task
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes: #325514
asyncorewas removed from the python-3.12 standard library: https://peps.python.org/pep-0594/Adding backport to 24.05 since its broken there as well (see output below).
This patch was original sourced from: seb-m/pyinotify#205 Its seems like
ipynotifyis no longer maintained so I'm opting to include the patch here. This is similar to what Arch (https://gitlab.archlinux.org/archlinux/packaging/packages/python-pyinotify/-/commit/df875e727a19fb9e83d2af55cc5f368b94eec705) and Fedora (https://src.fedoraproject.org/rpms/python-inotify/pull-request/4) have done:Testing
pythonImportsCheck = [ pyinotify ]failing prior to patch onmaster:Testing the
pythonImportsCheck = [ pyinotify ]againstrelease-24.05(acbecbb):Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.