ulauncher: add pyasyncore for Python 3.12 compat#327753
Closed
cluther wants to merge 1 commit into
Closed
Conversation
asyncore has been removed from Python 3.12. For applications that still
need it, the pyasyncore dependency can be explicitly added. So that's
what we'll do.
After nixpkgs updated to Python 3.12, I began getting the following
traceback when starting ulauncher.
Traceback (most recent call last):
File "/nix/store/rcqlxcr07aylib5sa7v38b4ba92jzxx4-ulauncher-5.15.7/bin/.ulauncher-wrapped", line 28, in <module>
from ulauncher.main import main
File "/nix/store/rcqlxcr07aylib5sa7v38b4ba92jzxx4-ulauncher-5.15.7/lib/python3.12/site-packages/ulauncher/main.py", line 25, in <module>
from ulauncher.ui.windows.UlauncherWindow import UlauncherWindow
File "/nix/store/rcqlxcr07aylib5sa7v38b4ba92jzxx4-ulauncher-5.15.7/lib/python3.12/site-packages/ulauncher/ui/windows/UlauncherWindow.py", line 37, in <module>
from ulauncher.search.apps.app_watcher import start as start_app_watcher
File "/nix/store/rcqlxcr07aylib5sa7v38b4ba92jzxx4-ulauncher-5.15.7/lib/python3.12/site-packages/ulauncher/search/apps/app_watcher.py", line 7, in <module>
import pyinotify
File "/nix/store/8bxngdzbnzig8ddw0ypdg1plsmrpqmi2-python3.12-pyinotify-0.9.6/lib/python3.12/site-packages/pyinotify.py", line 71, in <module>
import asyncore
ModuleNotFoundError: No module named 'asyncore'
Adding pyasyncore to propagatedBuildInputs solves this and ulauncher
functions normally with no errors logged.
Author
|
It appears that this change to ulauncher is no longer necessary. #325685 fixed it in pyinotify. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncore has been removed from Python 3.12. For applications that still
need it, the pyasyncore dependency can be explicitly added. So that's
what we'll do.
After nixpkgs updated to Python 3.12, I began getting the following
traceback when starting ulauncher.
Adding pyasyncore to propagatedBuildInputs solves this and ulauncher
functions normally with no errors logged.
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"../result/bin/)