Add suport for the fixed resolution target resolution when Aspect Bucketing is disabled#46
Open
maedtb wants to merge 2 commits intoNerogar:masterfrom
Open
Add suport for the fixed resolution target resolution when Aspect Bucketing is disabled#46maedtb wants to merge 2 commits intoNerogar:masterfrom
fixed resolution target resolution when Aspect Bucketing is disabled#46maedtb wants to merge 2 commits intoNerogar:masterfrom
Conversation
- Add support for fixed resolutions when aspect bucketing is disabled. - Adds optional support for quantizing the target image resolution to a model's required multiple. - Added calls to `.strip()` to fixed resolution inner values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Features/Changes
Added support for the
fixed resolutiontarget resolution format (i.e.1024x768) whenAspect Bucketingis disabled.Modified whitespace handling for the
fixed resolutiontarget resolution format, allowing for whitespace in more places. (i.e.1024 x 768).Added support for rounding an image's target resolution to the model's preferred resolution multiple when
Aspect Bucketingis disabled (matching what happens whenAspectBucketingis enabled.)Added warning message when an image's target resolution is rounded.
Internal Change
resolution overridesare no longer included in thepossible resolutionlist if that concept's override is disabled.Testing
Tested by creating multiple concepts with varying resolution targets, some needing rounding, some not, and then training a SDXL model for a few dozen steps with Aspect Bucketing enabled, and once again with Aspect Bucketing disabled.