Skip to content

Remove trailing f from convar default values#1771

Open
AdamTadeusz wants to merge 2 commits intoNeotokyoRebuild:masterfrom
AdamTadeusz:324_removeTrailingFFromConVarDefaultValues
Open

Remove trailing f from convar default values#1771
AdamTadeusz wants to merge 2 commits intoNeotokyoRebuild:masterfrom
AdamTadeusz:324_removeTrailingFFromConVarDefaultValues

Conversation

@AdamTadeusz
Copy link
Contributor

@AdamTadeusz AdamTadeusz commented Mar 2, 2026

Description

Removed trailing f from all convar definitions we have access to, offending convars were found with

	if (Q_stristr(pDefaultValue, "f") && !Q_stristr(pName, "__cl_neo_git_hash") && (Q_stristr(pDefaultValue, "0") || Q_stristr(pDefaultValue, "1") || Q_stristr(pDefaultValue, "2") || Q_stristr(pDefaultValue, "3") || Q_stristr(pDefaultValue, "4") || Q_stristr(pDefaultValue, "5") || Q_stristr(pDefaultValue, "6") || Q_stristr(pDefaultValue, "7") || Q_stristr(pDefaultValue, "8") || Q_stristr(pDefaultValue, "9")))
	{
		Assert(false);
	}

inside

void ConVar::Create(

Toolchain

  • Windows MSVC VS2022

Linked Issues

@AdamTadeusz AdamTadeusz requested a review from a team March 2, 2026 12:42
@Rainyan Rainyan self-requested a review March 2, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConVars with default float values have an unnecessary trailing f

1 participant