Skip to content

fix: resolve execute_sql AttributeError, default warehouse_id from env #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrevorMcCormick wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve execute_sql AttributeError, default warehouse_id from env #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/server/databricks_mcp_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,17 +192,17 @@ async def list_files(params: Dict[str, Any]) -> List[TextContent]:
# SQL tools
@self.tool(
name="execute_sql",
description="Execute a SQL statement with parameters: statement (required), warehouse_id (required), catalog (optional), schema (optional)",
description="Execute a SQL statement with parameters: statement (required), warehouse_id (optional, defaults to DATABRICKS_SQL_WAREHOUSE_ID env var), catalog (optional), schema (optional)",
)
async def execute_sql(params: Dict[str, Any]) -> List[TextContent]:
logger.info(f"Executing SQL with params: {params}")
try:
statement = params.get("statement")
warehouse_id = params.get("warehouse_id")
warehouse_id = params.get("warehouse_id") or os.environ.get("DATABRICKS_SQL_WAREHOUSE_ID")
catalog = params.get("catalog")
schema = params.get("schema")

result = await sql.execute_sql(statement, warehouse_id, catalog, schema)
result = await sql.execute_and_wait(statement, warehouse_id, catalog, schema)
return [{"text": json.dumps(result)}]
except Exception as e:
logger.error(f"Error executing SQL: {str(e)}")
Expand All @@ -229,4 +229,4 @@ async def main():
if hasattr(sys.stdout, 'reconfigure'):
sys.stdout.reconfigure(line_buffering=True)

asyncio.run(main())
asyncio.run(main())