fix: resolve execute_sql AttributeError, default warehouse_id from env#7
Open
TrevorMcCormick wants to merge 1 commit into
Open
fix: resolve execute_sql AttributeError, default warehouse_id from env#7TrevorMcCormick wants to merge 1 commit into
TrevorMcCormick wants to merge 1 commit into
Conversation
… env - The execute_sql tool called sql.execute_sql(), which doesn't exist in src/api/sql.py. Changed to sql.execute_and_wait() which polls for query completion and returns results. - Also made warehouse_id optional by falling back to the DATABRICKS_SQL_WAREHOUSE_ID environment variable, so users can configure it once in their server config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address an issue and offers an enhancement:
Bug Fix
execute_sqltool calledsql.execute_sql(), which doesn't exist insrc/api/sql.py. This caused:{"error": "module 'src.api.sql' has no attribute 'execute_sql'"}sql.execute_and_wait()which polls for query completion and returns results.Enhancement
warehouse_idoptional by falling back to theDATABRICKS_SQL_WAREHOUSE_IDenvironment variable. This lets users configure it once in their MCP server config (e.g.claude_desktop_config.json) rather than passing it on every call.