Update NPS within standard run_cfg file

[Radiation-Transport]

Update NPS to obtain suitable relative error as described in issue #498.

Summary by CodeRabbit

• Chores
  • Updated simulation parameters in multiple benchmark configurations to enhance consistency and reliability of performance testing scenarios.

[coderabbitai]

Walkthrough

Configuration values updated in the default run settings to increase particle sample counts (nps) across seven benchmark simulation cases, improving computational resolution for neutron transport analysis benchmarks.

Changes

Cohort / File(s)	Summary
Benchmark NPS Configuration Updates src/jade/resources/default_cfg/run_cfg.yml	Increased nps parameter values for multiple benchmark entries (ASPIS-Fe88, FNG-BKT, FNG-W, FNG-SiC, FNG-SS, FNG-HCPB, IPPE-CF, RCR-Sphere) ranging from 5× to 10× their original values, with a trailing newline added to ISIS-800MeV-C entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

• JADE#498: This PR directly addresses the feature request to increase NPS values for the same set of benchmark cases (ASPIS-Fe88, FNG-*, IPPE-CF, RCR-Sphere) specified in the issue.

Poem

🐰✨ Hop, hop, hooray! The numbers climb so high,
From eight to nine, and five times the sky,
More samples mean clearer visions to spy,
Benchmarks now sharper—oh my, oh my!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: updating NPS values in the standard run configuration file, which aligns with the changeset that modifies nps values across multiple benchmark entries.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 498-feature-request---statistic-to-be-improved-in-few-benchmarks

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/jade/resources/default_cfg/run_cfg.yml (1)

200-207: ⚠️ Potential issue | 🟠 Major

IPPE-CF update is currently overridden by a later duplicate key.

Line 207 sets IPPE-CF.nps to 1e9, but a second IPPE-CF block appears later (Line 321 onward) with nps: 1e8 (Line 328). With duplicate YAML keys, the later block typically wins, so this PR likely does not apply the intended IPPE-CF increase at runtime.

Suggested fix

 IPPE-CF:
   codes:
     d1s: []
     mcnp: []
     openmc: []
     serpent: []
   custom_input: 
-  nps: 1e8
+  nps: 1e9
   description: IPPE 252Cf experiment
   only_input: false

I’d also recommend removing/merging duplicate top-level benchmark keys in this file to avoid silent overrides.

Also applies to: 321-330

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/jade/resources/default_cfg/run_cfg.yml` around lines 200 - 207, The file
contains duplicate top-level benchmark keys for "IPPE-CF" so the later block
(with nps: 1e8) overrides the earlier nps: 1e9; fix by merging/removing the
duplicate blocks so only one "IPPE-CF" mapping exists and ensure its nps is set
to the intended value (1e9), keep the desired codes/custom_input entries from
both blocks when merging, and remove the redundant second "IPPE-CF" block to
avoid silent overrides.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@src/jade/resources/default_cfg/run_cfg.yml`:
- Around line 200-207: The file contains duplicate top-level benchmark keys for
"IPPE-CF" so the later block (with nps: 1e8) overrides the earlier nps: 1e9; fix
by merging/removing the duplicate blocks so only one "IPPE-CF" mapping exists
and ensure its nps is set to the intended value (1e9), keep the desired
codes/custom_input entries from both blocks when merging, and remove the
redundant second "IPPE-CF" block to avoid silent overrides.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 80360535-5f71-4238-b624-e0a95f0464b8

📥 Commits

Reviewing files that changed from the base of the PR and between 48f10eb and 1db18a1.

📒 Files selected for processing (1)

• src/jade/resources/default_cfg/run_cfg.yml

[dodu94]

Thanks Marco, @alexvalentine94 for info