DOC: Add Create a Pull Request section with draft PR guidance#5975
Draft
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Draft
DOC: Add Create a Pull Request section with draft PR guidance#5975blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:mainfrom
Conversation
github-actions
bot
added
type:Documentation
Contributor
|
Cool, @blowekamp Very glad to have such a guidance for PRs! 👍 Some more detailed comments coming up... |
N-Dekker
reviewed
Mar 21, 2026
| author has personally verified that: | ||
|
|
||
| - all automated CI tests pass, | ||
| - the implementation is correct and complete, |
Contributor
There was a problem hiding this comment.
Can you please make this:
- the implementation is correct, complete and well understood,
I think it's essential that we keep understanding the code, even when it is partially AI generated, to avoid cognitive debt. As I mentioned at https://discourse.itk.org/t/ai-generated-pull-requests-overwhelming-hard-to-review-carefully/7728/12?u=niels_dekker
N-Dekker
reviewed
Mar 21, 2026
Comment on lines
+254
to
+255
| Reviewer time is a finite human resource. Do not request a review before these | ||
| conditions are met. |
Contributor
There was a problem hiding this comment.
Please add something like:
When you request a reviewer to review your PR, allow the reviewer a
reasonable amount of time to do the review, before the PR is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.