Skip to content

[CHORE] enforce python version compatibility #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aarmoa merged 2 commits into from
Mar 3, 2026
Merged

[CHORE] enforce python version compatibility #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1552bad
[CHORE] Added cap on max Python supported version to 3.12
aarmoa Mar 3, 2026
f6220b1
[CHORE] Updated poetry.lock file
aarmoa Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
run-tests:
strategy:
matrix:
python: ["3.10", "3.11", "3.12"]
python: ["3.10", "3.11", "3.12", "3.13", "3.14"]
Copy link
Contributor

@coderabbitai coderabbitai bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

cat -n .github/workflows/run-tests.yml | head -20

Repository: InjectiveLabs/sdk-python

Length of output: 624

🏁 Script executed:

cat -n pyproject.toml | grep -A 5 -B 5 "python\s*="

Repository: InjectiveLabs/sdk-python

Length of output: 435

CI matrix includes unsupported Python versions—Poetry install will fail for 3.13 and 3.14

Line 11 tests Python 3.13 and 3.14, but pyproject.toml restricts support to python = ">=3.10,<3.13". The poetry install step will fail for those two jobs on both OS runners.

Proposed fix 
-        python: ["3.10", "3.11", "3.12", "3.13", "3.14"]
+        python: ["3.10", "3.11", "3.12"]
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
python: ["3.10", "3.11", "3.12", "3.13", "3.14"]
python: ["3.10", "3.11", "3.12"]
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/run-tests.yml at line 11, The CI Python matrix in
.github/workflows/run-tests.yml currently includes "3.13" and "3.14" which
conflict with the package constraint in pyproject.toml (python =
">=3.10,<3.13"); update the python matrix (the python: [ ... ] entry) to match
supported versions—e.g., ["3.10","3.11","3.12"]—or alternatively relax the
pyproject.toml python constraint if you intend to support 3.13/3.14; ensure the
python matrix and the pyproject.toml python field are consistent.

os: [ubuntu-latest, macos-latest]
Comment on lines 10 to 12
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test matrix now includes Python 3.13 and 3.14, but pyproject.toml caps supported versions at <3.13. poetry install will fail for 3.13+ because the project declares it unsupported; either remove 3.13/3.14 from the matrix or update the declared support range (and tooling) to match the CI intent.

Copilot uses AI. Check for mistakes.
runs-on: ${{ matrix.os }}
env:
Expand Down
6 changes: 3 additions & 3 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "injective-py"
version = "1.13.0"
version = "1.13.1"
description = "Injective Python SDK, with Exchange API Client"
authors = ["Injective Labs <contact@injectivelabs.org>"]
license = "Apache-2.0"
Expand All @@ -21,7 +21,7 @@ include = [
]

[tool.poetry.dependencies]
python = "^3.10"
python = ">=3.10,<3.13"
aiohttp = "^3.9.4" # Version dependency due to https://github.com/InjectiveLabs/sdk-python/security/dependabot/18
bech32 = "*"
bip32 = "*"
Expand Down Expand Up @@ -82,7 +82,7 @@ skip_glob = ["pyinjective/proto/*", ".idea/*"]

[tool.black]
line-length = 120
target-version = ["py39", "py310", "py311"]
target-version = ["py310", "py311", "py312"]
include = '\.pyi?$'
# 'extend-exclude' excludes files or directories in addition to the defaults
extend-exclude = '''
Expand Down