[CHORE] enforce python version compatibility#408
Conversation
📝 WalkthroughWalkthroughMaintenance release updating the project to version 1.13.1, expanding the CI test matrix to include Python 3.13 and 3.14, restricting the package's Python dependency constraint to <3.13, and updating Black tool target versions to [py310, py311, py312]. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR aims to enforce Python version compatibility by capping the package’s supported Python versions at 3.12 (i.e., <3.13) and aligning tooling configuration accordingly.
Changes:
- Bumped project version to
1.13.1. - Updated Poetry Python requirement to
>=3.10,<3.13(max Python 3.12). - Updated Black formatting targets to include Python 3.12.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyproject.toml |
Caps supported Python versions at <3.13 and aligns Black target versions with 3.10–3.12. |
.github/workflows/run-tests.yml |
Expands the CI test matrix Python versions (currently includes 3.13/3.14). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| matrix: | ||
| python: ["3.10", "3.11", "3.12"] | ||
| python: ["3.10", "3.11", "3.12", "3.13", "3.14"] | ||
| os: [ubuntu-latest, macos-latest] |
There was a problem hiding this comment.
The test matrix now includes Python 3.13 and 3.14, but pyproject.toml caps supported versions at <3.13. poetry install will fail for 3.13+ because the project declares it unsupported; either remove 3.13/3.14 from the matrix or update the declared support range (and tooling) to match the CI intent.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/run-tests.yml:
- Line 11: The CI Python matrix in .github/workflows/run-tests.yml currently
includes "3.13" and "3.14" which conflict with the package constraint in
pyproject.toml (python = ">=3.10,<3.13"); update the python matrix (the python:
[ ... ] entry) to match supported versions—e.g., ["3.10","3.11","3.12"]—or
alternatively relax the pyproject.toml python constraint if you intend to
support 3.13/3.14; ensure the python matrix and the pyproject.toml python field
are consistent.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
.github/workflows/run-tests.ymlpyproject.toml
| strategy: | ||
| matrix: | ||
| python: ["3.10", "3.11", "3.12"] | ||
| python: ["3.10", "3.11", "3.12", "3.13", "3.14"] |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat -n .github/workflows/run-tests.yml | head -20Repository: InjectiveLabs/sdk-python
Length of output: 624
🏁 Script executed:
cat -n pyproject.toml | grep -A 5 -B 5 "python\s*="Repository: InjectiveLabs/sdk-python
Length of output: 435
CI matrix includes unsupported Python versions—Poetry install will fail for 3.13 and 3.14
Line 11 tests Python 3.13 and 3.14, but pyproject.toml restricts support to python = ">=3.10,<3.13". The poetry install step will fail for those two jobs on both OS runners.
Proposed fix
- python: ["3.10", "3.11", "3.12", "3.13", "3.14"]
+ python: ["3.10", "3.11", "3.12"]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| python: ["3.10", "3.11", "3.12", "3.13", "3.14"] | |
| python: ["3.10", "3.11", "3.12"] |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/run-tests.yml at line 11, The CI Python matrix in
.github/workflows/run-tests.yml currently includes "3.13" and "3.14" which
conflict with the package constraint in pyproject.toml (python =
">=3.10,<3.13"); update the python matrix (the python: [ ... ] entry) to match
supported versions—e.g., ["3.10","3.11","3.12"]—or alternatively relax the
pyproject.toml python constraint if you intend to support 3.13/3.14; ensure the
python matrix and the pyproject.toml python field are consistent.
Summary by CodeRabbit