Move h5inspect_post execution inside the app loop#12
Merged
Conversation
Co-authored-by: HalFrgrd <4559349+HalFrgrd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move h5inspect post to run during main app loop
Move h5inspect_post execution inside the app loop
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, pressing
iexited the TUI, ran the post command, then restarted the app from scratch. The post command now runs inline without losing app state.Changes
KeyPressResultenum —handle_keypress(and its sub-handlers) now returnRedraw | DontRedraw | RunPostCommand(Option<String>, String)instead of()RunPostCommandhandled inrun()loop — wheniis pressed, the loop pauses the TUI (disable raw mode + leave alternate screen), runs the post command, then restores the TUI (re-enter alternate screen + enable raw mode +terminal.clear()); terminal errors are logged vialog::warn!AppFinishingState::ShouldRunCommand— no longer needed;AppFinishingStateis now justContinue | Quitmain.rs— outerloopand post-command dispatch logic removed;run()is called onceOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.