Restore tests broken by post-command refactor#15
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
…ic over backend, restore async event handler Co-authored-by: HalFrgrd <4559349+HalFrgrd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with trigger not activating on recent commits
Restore tests broken by post-command refactor
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests were silently disabled after PR #12 moved
h5inspect_postexecution insideapp.run(), causing CI to pass on all subsequent master commits with zero tests running.Why tests broke
ratatui::init()moved insiderun()— panics in non-TTY CI environments (enable_raw_mode()fails without a real terminal), makingTestBackend-based tests impossible.Sync event polling replaced async handler —
events.rswas changed from a tokio-spawnedEventStreamtask to synchronouscrossterm::event::poll(). A blocking call insideasync fn run()starves the tokio executor, sotokio::select!timeouts never fire and tests hang.Changes
app.rs:run()now acceptsTerminal<B: Backend>+ areinit_terminal: impl Fn() -> Terminal<B>callback, preserving the in-loop post-command behavior (no app state loss) without hardcodingratatui::init()events.rs: Restored the asyncEventHandlerusingEventStreamin a spawned tokio task withreceiver.recv().awaitin the event loop — compatible withtokio::select!cancellationmain.rs: Passesratatui::init()terminal and reinit closure torun(); tests uncommented and updated to passTestBackendterminal + no-op reinitOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.