Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: NaN values to coupler after about 1 year of eCLM simulation with LSTDA.
Goal: Introduce more checks to the LSTDA-update
remark: co-authored by Claude-Code
Summary
spval filter on t_veg: Excludes non-vegetated patches (t_veg = 1e36) fromTVEG averaging and updates. Falls back to TSKIN mean for fully non-vegetated
gridcells instead of crashing.
Per-column update guard (col_updated): Prevents TSOIL increments from beingapplied multiple times to the same column when multiple patches share it.
NaN check on increment_factor: Fortran's abs(NaN) < threshold silentlyevaluates to .false., bypassing the cap. An explicit ieee_is_nan guard leaves
the variable unchanged instead.
Temperature clamp [TKFRZ−130, TKFRZ+100]: Last-resort physical bounds checkon all updated temperatures.