Skip to content

Robustness guards for LSTDA#47

Closed
jjokella wants to merge 1 commit intoHPSCTerrSys:tsmp-pdaf-patched-lstdafrom
visakhraja:tsmp-pdaf-patched-lstda-cap
Closed

Robustness guards for LSTDA#47
jjokella wants to merge 1 commit intoHPSCTerrSys:tsmp-pdaf-patched-lstdafrom
visakhraja:tsmp-pdaf-patched-lstda-cap

Conversation

@jjokella
Copy link
Collaborator

@jjokella jjokella commented Mar 3, 2026

Problem: NaN values to coupler after about 1 year of eCLM simulation with LSTDA.

Goal: Introduce more checks to the LSTDA-update

remark: co-authored by Claude-Code

Summary

  1. spval filter on t_veg: Excludes non-vegetated patches (t_veg = 1e36) from
    TVEG averaging and updates. Falls back to TSKIN mean for fully non-vegetated
    gridcells instead of crashing.
  2. Per-column update guard (col_updated): Prevents TSOIL increments from being
    applied multiple times to the same column when multiple patches share it.
  3. NaN check on increment_factor: Fortran's abs(NaN) < threshold silently
    evaluates to .false., bypassing the cap. An explicit ieee_is_nan guard leaves
    the variable unchanged instead.
  4. Temperature clamp [TKFRZ−130, TKFRZ+100]: Last-resort physical bounds check
    on all updated temperatures.

@jjokella jjokella changed the title Added cap for LSTDA Robustness guards for LSTDA Mar 3, 2026
@jjokella
Copy link
Collaborator Author

jjokella commented Mar 3, 2026

Moved to #50 with the branch inside the repo.

@jjokella jjokella closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants