Skip to content

Add Chip Design environment #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephdviviano merged 33 commits into from
Apr 4, 2026
Merged

Add Chip Design environment #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
fad7fff
add chip design
younik Oct 7, 2025
8e75917
resore helpers init
younik Oct 7, 2025
a0ebee7
refactor
younik Oct 23, 2025
3162cdf
add PLC wrapper main
younik Oct 25, 2025
33d2e50
fixes
younik Oct 28, 2025
0e583a7
fixes, refactor & tests
younik Oct 28, 2025
02ea32f
pre-commit
younik Oct 28, 2025
50aa67b
fix pre-commit + add credits
younik Oct 30, 2025
af71459
add initial printing
younik Nov 2, 2025
fd720e7
Replace bundled binary with download script + Apptainer support
josephdviviano Apr 3, 2026
40efe96
Merge origin/master into chip-design
josephdviviano Apr 3, 2026
62a4632
Add singularity wrapper for plc_wrapper_main and fix master compat
josephdviviano Apr 3, 2026
e5840d6
Fix CUDA/CPU device mismatch in States._compare
josephdviviano Apr 3, 2026
5c93883
Fix pyright type error and apply black formatting
josephdviviano Apr 3, 2026
52844e3
Merge origin/chip-design: integrate download script + apptainer support
josephdviviano Apr 3, 2026
9553cf3
black
josephdviviano Apr 3, 2026
4828ada
Restore plc_wrapper_main binary
josephdviviano Apr 3, 2026
72f575b
Note GCS 403 in setup_plc.sh, binary is bundled in repo
josephdviviano Apr 3, 2026
db77255
Fix missing singularity_image attr in ChipDesignArgs test dataclass
josephdviviano Apr 3, 2026
5750cfd
Apply suggestion from @Copilot
josephdviviano Apr 3, 2026
b290752
Fix get_blockages_from_comments to handle single string input correctly
Copilot Apr 3, 2026
ef01743
Add close() and __del__() to ChipDesign to prevent PlacementCost subp…
Copilot Apr 3, 2026
9bf824b
Apply suggestions from code review
josephdviviano Apr 3, 2026
d3965a1
Fix multi-dim batch_shape support in ChipDesign env
josephdviviano Apr 3, 2026
e1be0c9
Remove duplicate singularity_image field in ChipDesignArgs
josephdviviano Apr 3, 2026
42961da
Add coordinate descent orientation optimization
josephdviviano Apr 3, 2026
3a4e17d
Add --cd_finetune flag and CD comparison to train_chip_design.py
josephdviviano Apr 3, 2026
6efa774
Add reward normalization (zscore/minmax) with pre-computable stats
josephdviviano Apr 3, 2026
c046e97
Add missing cd_finetune to ChipDesignArgs test dataclass
josephdviviano Apr 3, 2026
4613764
Add chip_design test suite (48 tests) and fix empty batch in update_m…
josephdviviano Apr 4, 2026
cc7132f
black
josephdviviano Apr 4, 2026
9c1cc31
isort
josephdviviano Apr 4, 2026
ba6f878
Remove unused imports in test_chip_design.py
josephdviviano Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,11 +184,20 @@ wandb
*.sh
*.out

# Chip design: allow setup/wrapper scripts, ignore downloaded binary and container
!src/gfn/gym/helpers/chip_design/setup_plc.sh
!src/gfn/gym/helpers/chip_design/run_plc_apptainer.sh
src/gfn/gym/helpers/chip_design/plc_wrapper_main
src/gfn/gym/helpers/chip_design/plc.sif

scripts.py

models/
*.DS_Store
.python-version

.lprof
.claude/
.claude/

# Singularity images
*.sif
35 changes: 17 additions & 18 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,23 @@ reportUnboundVariable = "warning"
reportGeneralTypeIssues = "none"
reportAttributeAccessIssue = false

[tool.pytest.ini_options]
pythonpath = [
"tutorials",
"testing",
]
reportOptionalMemberAccess = "error"
filterwarnings = [
"ignore::pytest.PytestConfigWarning",
]
reportUnusedImport = true
reportUnusedVariable = true
reportOptionalSubscript = true
reportOptionalCall = true
reportOptionalIterable = true
reportOptionalContextManager = true
reportOptionalOperand = true
Comment on lines 178 to +194
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [tool.pytest.ini_options] section contains several report* settings that belong to Pyright, not Pytest, so they will be ignored (and may emit/require suppressing config warnings). Consider keeping only valid pytest ini options here (e.g., pythonpath, filterwarnings) and moving/removing the report* settings under [tool.pyright] where they take effect.

Suggested change
[tool.pytest.ini_options]
pythonpath = [
"tutorials",
"testing",
]
reportOptionalMemberAccess = "error"
filterwarnings = [
"ignore::pytest.PytestConfigWarning",
]
reportUnusedImport = true
reportUnusedVariable = true
reportOptionalSubscript = true
reportOptionalCall = true
reportOptionalIterable = true
reportOptionalContextManager = true
reportOptionalOperand = true
reportOptionalMemberAccess = "error"
reportUnusedImport = true
reportUnusedVariable = true
reportOptionalSubscript = true
reportOptionalCall = true
reportOptionalIterable = true
reportOptionalContextManager = true
reportOptionalOperand = true
[tool.pytest.ini_options]
pythonpath = [
"tutorials",
"testing",
]
filterwarnings = [
"ignore::pytest.PytestConfigWarning",
]

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

@josephdviviano josephdviviano Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot can you make a new PR that only changes pyproject.toml and submits it to master? This is a distinct issue that does not belong in this pr.


[tool.tox]
legacy_tox_ini = '''
[tox]
Expand All @@ -198,24 +215,6 @@ use_parentheses = true
ensure_newline_before_comments = true
src_paths = ["src"]

[tool.pytest]
pythonpath = [
"tutorials",
"testing"
]
reportOptionalMemberAccess = "error"
filterwarnings = [
"ignore::pytest.PytestConfigWarning",
]
# Add some useful, commonly used settings.
reportUnusedImport = true
reportUnusedVariable = true
reportOptionalSubscript = true
reportOptionalCall = true
reportOptionalIterable = true
reportOptionalContextManager = true
reportOptionalOperand = true

[tool.coverage.run]
source = ["gfn"]
branch = true
Expand Down
2 changes: 2 additions & 0 deletions src/gfn/gym/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from .bitSequenceNonAutoregressive import NonAutoregressiveBitSequence
from .box import BoxPolar
from .box_cartesian import BoxCartesian
from .chip_design import ChipDesign
from .discrete_ebm import DiscreteEBM
from .graph_building import GraphBuilding, GraphBuildingOnEdges
from .hypergrid import ConditionalHyperGrid, HyperGrid
Expand All @@ -18,6 +19,7 @@
"Box",
"BoxCartesian",
"BoxPolar",
"ChipDesign",
"DiscreteEBM",
"HyperGrid",
"ConditionalHyperGrid",
Expand Down
Loading
Loading