Fix MassListBaseClass ignoring user-configured DataInputSetting#27
Open
robertyoung3 wants to merge 1 commit intoEMSL-Computing:masterfrom
Open
Fix MassListBaseClass ignoring user-configured DataInputSetting#27robertyoung3 wants to merge 1 commit intoEMSL-Computing:masterfrom
robertyoung3 wants to merge 1 commit intoEMSL-Computing:masterfrom
Conversation
5c05543 to
4f750af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MassListBaseClass.__init__usesdeepcopy(DataInputSetting())which always creates a fresh default instanceMSParameters.data_input(e.g. customheader_translatemappings)deepcopy(MSParameters.data_input)to respect user-configured parameters, consistent with how other parameter classes are used throughout CoreMSBefore
After
Test plan
MSParameters.data_inputis the canonical source used elsewhere in the codebase (e.g.parameters.pyline 77, 85, 91)DataInputSettingimport is no longer needed (remaining references are in docstrings and parameter names only)