Skip to content

Fix MassListBaseClass ignoring user-configured DataInputSetting#27

Open
robertyoung3 wants to merge 1 commit intoEMSL-Computing:masterfrom
robertyoung3:fix/masslist-parameter-source
Open

Fix MassListBaseClass ignoring user-configured DataInputSetting#27
robertyoung3 wants to merge 1 commit intoEMSL-Computing:masterfrom
robertyoung3:fix/masslist-parameter-source

Conversation

@robertyoung3
Copy link

Summary

  • MassListBaseClass.__init__ uses deepcopy(DataInputSetting()) which always creates a fresh default instance
  • This ignores any user customizations set on MSParameters.data_input (e.g. custom header_translate mappings)
  • Changed to deepcopy(MSParameters.data_input) to respect user-configured parameters, consistent with how other parameter classes are used throughout CoreMS

Before

from corems.encapsulation.factory.processingSetting import DataInputSetting
...
self._parameters = deepcopy(DataInputSetting())

After

from corems.encapsulation.factory.parameters import MSParameters, default_parameters
...
self._parameters = deepcopy(MSParameters.data_input)

Test plan

  • Verified MSParameters.data_input is the canonical source used elsewhere in the codebase (e.g. parameters.py line 77, 85, 91)
  • DataInputSetting import is no longer needed (remaining references are in docstrings and parameter names only)

@robertyoung3 robertyoung3 force-pushed the fix/masslist-parameter-source branch from 5c05543 to 4f750af Compare March 3, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant