Fix duplicated variable in baseline noise check#25
Open
robertyoung3 wants to merge 1 commit intoEMSL-Computing:masterfrom
Open
Fix duplicated variable in baseline noise check#25robertyoung3 wants to merge 1 commit intoEMSL-Computing:masterfrom
robertyoung3 wants to merge 1 commit intoEMSL-Computing:masterfrom
Conversation
kheal
reviewed
Mar 2, 2026
Collaborator
kheal
left a comment
There was a problem hiding this comment.
Hi @robertyoung3, thanks for putting in this PR.
Generally speaking, the requested functionality change / bug fix looks good.
However, we don't want to add the extraneous changes (the .claude/, .devcontainer/, openspec/, changes to docker- etc) in this PR. Could you cull this PR to the minimum diff changes needed to repair the functionality you've described? Essentially just the change in MassSpectrumClasses.py module. We'd want this for the other PRs you've put in as well (#26, #27, #28, #29).
Thanks in advance!
21e5794 to
a19d964
Compare
Author
|
Hi Katherine, |
kheal
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MassSpecBase.plot_mz_domain_profile()(line 1094) checksself.baseline_noise_stdtwice instead of checkingself.baseline_noiseandself.baseline_noise_stdis not Noneso valid0.0values are not incorrectly treated as missingBefore
After
Test plan
self.baseline_noise)