Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds camera recording configuration to the CartPole GRPO training config so evaluation runs can generate videos (via the trainer event system).
Changes:
- Switch CartPole GRPO training config device to
cuda:0. - Add
trainer.events.eval.record_camerausingrecord_camera_data_asyncto save videos to./outputs/videos/eval. - Adjust GRPO
ent_coeffrom0.001to0.01.
Comments suppressed due to low confidence (3)
configs/agents/rl/basic/cart_pole/train_config_grpo.json:7
- PR description says this change is about adding camera recording, but this config also changes the default device from CPU to CUDA. If this is intentional, please update the PR description (or split into a separate PR); otherwise revert to the previous device to keep the PR scoped to camera recording.
"seed": 42,
"device": "cuda:0",
"headless": true,
configs/agents/rl/basic/cart_pole/train_config_grpo.json:23
- The new camera recording is configured under
trainer.events.eval, so it will only run during evaluation episodes (perTrainer._eval_once), not during training rollouts. If the intent is to "record grpo training", consider moving/duplicating this undertrainer.events.train; otherwise please clarify the PR description to explicitly say it records evaluation.
"events": {
"eval": {
"record_camera": {
"func": "record_camera_data_async",
"mode": "interval",
"interval_step": 1,
configs/agents/rl/basic/cart_pole/train_config_grpo.json:56
- PR description focuses on camera recording, but this change also increases
algorithm.cfg.ent_coef(0.001 → 0.01), which will materially change GRPO behavior. If this tuning is intended, please document it in the PR description (or split it into a separate PR); otherwise revert so the PR stays scoped to the camera feature.
"gamma": 0.99,
"clip_coef": 0.2,
"ent_coef": 0.01,
"kl_coef": 0.0,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add camera to record grpo training
Type of change
Checklist
black .command to format the code base.