Format Connection Details clearly#31
Open
emmuhamm wants to merge 5 commits into
Open
Conversation
762fc92 to
e6de56d
Compare
Author
|
Hi @gcrone @PawelPlesniak, this PR is ready for review. All it does is fix up the formatting of the table a bit so its a bit clearer to read. Can you have a look and lmk what you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #30
Formats the connectivity service output into a nice table.
Before:

After:

After, with expired sessions:
For this image please just focus on the red text and not the titles
Review instructions
Check out this branch on develop (this was tested on the nightly of 2026-04-23)
Run a simple instance of drunc, eg
drunc-unified-shell ssh-standalone config/daqsystemtest/example-configs.data.xml local-1x1-config emir-test boot start-shellView the connectivity service on the browser
Connectivity server localhost:30005 is enabledType of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))