Skip to content

Format Connection Details clearly#31

Open
emmuhamm wants to merge 5 commits into
developfrom
emmuhamm/tables
Open

Format Connection Details clearly#31
emmuhamm wants to merge 5 commits into
developfrom
emmuhamm/tables

Conversation

@emmuhamm
Copy link
Copy Markdown

@emmuhamm emmuhamm commented Apr 27, 2026

Description

Fixes #30

Formats the connectivity service output into a nice table.

Before:
Screenshot 2026-04-27 at 13 23 38

After:
Screenshot 2026-04-27 at 16 28 53

After, with expired sessions:
For this image please just focus on the red text and not the titles

Screenshot 2026-04-27 at 13 51 32

Review instructions

Check out this branch on develop (this was tested on the nightly of 2026-04-23)

Run a simple instance of drunc, eg drunc-unified-shell ssh-standalone config/daqsystemtest/example-configs.data.xml local-1x1-config emir-test boot start-shell

View the connectivity service on the browser

  • You'll have to find the URI of the connectivity service. Check the output of eg. the root controller: Connectivity server localhost:30005 is enabled
  • If its on the np04 machines, dont forget to enable the proxys
  • See the new table and check its all good

Type of change

  • New feature or enhancement (non-breaking change which adds functionality)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@emmuhamm emmuhamm self-assigned this Apr 27, 2026
@emmuhamm
Copy link
Copy Markdown
Author

Hi @gcrone @PawelPlesniak, this PR is ready for review. All it does is fix up the formatting of the table a bit so its a bit clearer to read.

Can you have a look and lmk what you think?

@emmuhamm emmuhamm requested review from PawelPlesniak and gcrone May 13, 2026 10:28
Copy link
Copy Markdown
Collaborator

@gcrone gcrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Format the ConnnectionDetals parameters more clearly, preferably in a table

3 participants