Skip to content

Patch Vite dependency and document metadata parser risk #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisAdamsdevelopment merged 1 commit into from
May 4, 2026
Merged

Patch Vite dependency and document metadata parser risk #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/manual-qa-checklist.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,5 +160,6 @@ Run these checks against your local server:
## 13) Known warnings

- `npm audit` currently reports vulnerabilities and should be triaged.
- `music-metadata-browser` is deprecated; monitor and replace in a later maintenance cycle.
- `music-metadata-browser` is deprecated and currently used only for browser-side metadata analysis; plan a replacement/redesign in a future PR.
- Treat suspicious or corrupt media samples as high-risk during manual QA and verify metadata analysis paths carefully.
- Docker build/runtime validation still requires a real Docker-capable environment.
10 changes: 5 additions & 5 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 8 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,13 @@
"dependencies": {
"@tokenizer/http": "^0.9.2",
"@tokenizer/range": "^0.13.1",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"@vitejs/plugin-react": "^4.2.1",
"autoprefixer": "^10.4.19",
"bcryptjs": "^2.4.3",
"better-sqlite3": "^9.6.0",
"browser-id3-writer": "4.4.0",
"cors": "^2.8.5",
"dotenv": "^16.4.5",
"exiftool-vendored": "^28.3.1",
Comment on lines +19 to 28
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): Consider keeping tooling and type packages in devDependencies instead of dependencies.

These packages are only required at build time, so they should live under devDependencies (and the devDependencies section should be reintroduced). This keeps the production install smaller and clearly distinguishes runtime from build-time dependencies, which is especially helpful for lean production images and functions.

Expand All @@ -27,20 +32,14 @@
"lucide-react": "^0.390.0",
"multer": "^2.0.0",
"music-metadata": "^11.12.3",
"music-metadata-browser": "2.5.11",
"postcss": "^8.4.38",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"stripe": "^16.2.0",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"@vitejs/plugin-react": "^4.2.1",
"autoprefixer": "^10.4.19",
"postcss": "^8.4.38",
"tailwindcss": "^3.4.4",
"typescript": "^5.5.2",
"vite": "^4.5.3",
"browser-id3-writer": "4.4.0",
"music-metadata-browser": "2.5.11"
"vite": "^4.5.14"
},
"devDependencies": {},
"license": "MIT"
}
Loading