Patch Vite dependency and document metadata parser risk

[ChrisAdamsdevelopment]

Motivation

• Apply a narrow, low-risk dependency security update to keep Vite on the latest safe patch in the 4.5.x line and avoid framework churn.
• Re-evaluate whether the Vite patch reduces transitive esbuild exposure without introducing breaking changes.
• Surface remaining risk from the deprecated music-metadata-browser dependency for manual QA without replacing it in this PR.

Description

• Bumped vite from ^4.5.3 to ^4.5.14 in package.json and regenerated package-lock.json to capture updated transitive versions.
• Added a short note to docs/manual-qa-checklist.md documenting that music-metadata-browser is deprecated, used only for browser-side metadata analysis, should be replaced/redesigned in a future PR, and that suspicious/corrupt media requires careful QA.
• No application behavior, API contracts, auth/Stripe/usage logic, cleanse logic, Dockerfile, or UI changes were made; changes are limited to package.json, package-lock.json, and the QA docs.
• Did not replace or downgrade music-metadata-browser because no safe, non-breaking drop-in was available within the scope and risk constraints of this patch.

Testing

• Ran npm audit --json before and after the Vite update; vulnerability counts remained 5 total (3 moderate, 2 high) and the vite and transitive esbuild advisories still appear (no resolution by the patch).
• Ran npm install successfully and regenerated package-lock.json to reflect vite@4.5.14 and its transitive dependencies.
• Ran npm run build successfully (production build completes; warning about file-type eval usage noted but build artifacts produced).
• Ran npm outdated || true to surface newer majors; command executed successfully and no further upgrades were applied in this PR.

---

Codex Task

Summary by Sourcery

Update Vite to the latest 4.5.x patch and document QA risks around the deprecated music-metadata-browser dependency.

Enhancements:

• Upgrade Vite dependency from 4.5.3 to 4.5.14 to pick up the latest safe patch within the 4.5.x line.

Build:

• Regenerate package-lock.json to capture the updated Vite version and its transitive dependencies.

Documentation:

• Expand the manual QA checklist to clarify music-metadata-browser’s deprecated status, its limited browser-side usage, and the need for extra care with suspicious or corrupt media samples during testing.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates Vite and related build-time dependencies to the latest 4.5.x patch and refreshes the lockfile, while documenting ongoing risk around the deprecated music-metadata-browser dependency for manual QA.

File-Level Changes

Change	Details	Files
Upgrade Vite and reorganize frontend/build dependencies in package.json, regenerating package-lock.json accordingly.	Bumped vite from ^4.5.3 to ^4.5.14 to pick up the latest non-breaking patch in the 4.5.x line. Reordered and grouped React, React type definitions, Vite React plugin, Tailwind/PostCSS/autoprefixer, browser-id3-writer, and music-metadata-browser dependencies under a consolidated dependencies section. Regenerated package-lock.json to align with the updated vite version and its transitive dependencies, including esbuild.	package.json package-lock.json
Document deprecated music-metadata-browser usage and add QA guidance for handling risky media inputs.	Expanded the manual QA checklist note to clarify that music-metadata-browser is deprecated and currently used only for browser-side metadata analysis, with replacement deferred to a future PR. Added guidance for treating suspicious or corrupt media samples as high risk during manual QA and for carefully validating metadata analysis paths.	docs/manual-qa-checklist.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• Consider moving build-time-only packages like @types/*, @vitejs/plugin-react, autoprefixer, postcss, tailwindcss, typescript, and possibly vite into devDependencies to better reflect their usage and avoid inflating the production dependency surface.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider moving build-time-only packages like `@types/*`, `@vitejs/plugin-react`, `autoprefixer`, `postcss`, `tailwindcss`, `typescript`, and possibly `vite` into `devDependencies` to better reflect their usage and avoid inflating the production dependency surface.

## Individual Comments

### Comment 1
<location path="package.json" line_range="19-28" />
<code_context>
   "dependencies": {
     "@tokenizer/http": "^0.9.2",
     "@tokenizer/range": "^0.13.1",
+    "@types/react": "^18.3.3",
+    "@types/react-dom": "^18.3.0",
+    "@vitejs/plugin-react": "^4.2.1",
</code_context>
<issue_to_address>
**suggestion (performance):** Consider keeping tooling and type packages in devDependencies instead of dependencies.

These packages are only required at build time, so they should live under `devDependencies` (and the `devDependencies` section should be reintroduced). This keeps the production install smaller and clearly distinguishes runtime from build-time dependencies, which is especially helpful for lean production images and functions.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[sourcery-ai]

suggestion (performance): Consider keeping tooling and type packages in devDependencies instead of dependencies.

These packages are only required at build time, so they should live under devDependencies (and the devDependencies section should be reintroduced). This keeps the production install smaller and clearly distinguishes runtime from build-time dependencies, which is especially helpful for lean production images and functions.