Skip to content

fix: prevents default home page laggy scroll animation #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkisDev merged 3 commits into from
Apr 19, 2026
Merged

fix: prevents default home page laggy scroll animation #870

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
edb8309
fix: Stopped the laggy UI animation everytime the app is rebuilt
devxdebanjan Mar 9, 2026
08e95d9
fix: Used confirmDismiss instead of ondismissed which prevents unnece…
devxdebanjan Mar 10, 2026
588dae0
fix: prevents default animation for when multipleSelected mode is true
devxdebanjan Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions lib/app/modules/home/views/home_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ class HomeView extends GetView<HomeController> {
final GlobalKey<ScaffoldState> scaffoldKey = GlobalKey<ScaffoldState>();
var width = Get.width;
var height = Get.height;

// Homeview resetted to expanded state whenever HomeView is rebuilt.
controller.scalingFactor.value = 1.0;

return Scaffold(
floatingActionButtonLocation: FloatingActionButtonLocation.centerFloat,
floatingActionButton: Obx(
Expand Down Expand Up @@ -68,7 +72,8 @@ class HomeView extends GetView<HomeController> {
actions: [Container()],
automaticallyImplyLeading: false,
expandedHeight: height / 7.9,
floating: true,
collapsedHeight: height / 7.9,
floating: false,
pinned: true,
snap: false,
centerTitle: true,
Expand Down Expand Up @@ -249,7 +254,8 @@ class HomeView extends GetView<HomeController> {
automaticallyImplyLeading: false,
actions: [Container()],
expandedHeight: height / 7.9,
floating: true,
collapsedHeight: height / 7.9,
floating: false,
pinned: true,
snap: false,
centerTitle: true,
Expand Down Expand Up @@ -554,8 +560,8 @@ class HomeView extends GetView<HomeController> {
return alarm.profile ==
controller.selectedProfile.value
? Dismissible(
onDismissed: (direction) async {
// pop up confirmation to delete on swipe
confirmDismiss: (direction) async {
// Show confirmation dialog BEFORE removing the item
bool userConfirmed =
await showDeleteAlarmConfirmationPopupOnSwipe(
context,
Expand All @@ -566,13 +572,8 @@ class HomeView extends GetView<HomeController> {
alarm,
);
}

Get.offNamedUntil(
'/bottom-navigation-bar',
(route) =>
route.settings.name ==
'/splash-screen',
);
// Returning true if delete is confirmed, false otherwise
return userConfirmed;
},
key: ValueKey(alarms[index]),
background: Container(
Expand Down