fix: prevents default home page laggy scroll animation#870
Open
devxdebanjan wants to merge 3 commits intoCCExtractor:mainfrom
Open
fix: prevents default home page laggy scroll animation#870devxdebanjan wants to merge 3 commits intoCCExtractor:mainfrom
devxdebanjan wants to merge 3 commits intoCCExtractor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the default UI animation where the screen appears to contract on its own every time page is switched from Timer or Stopwatch to Home.
While testing it however I found another bug.
There is another problem which appears: the alarm swipe delete feature builds the whole alarm home page from scratch whenever the alarm is swiped to delete it. This is due to using onDismissed and using GetOffUntil rather than only confirmDismiss for the confirmation dialog box. Because merging the UI animation fix without the SwipeDelete fix would break things, both fixes are added together. But both of them are in complete different commits.
This is what could occur if the Confirmation Dialog Box issue was not fixed along with the Scroll Animation Issue:
issuevid2compressed.mp4
Proposed Changes
Fixes #869
Screenshots
issue1fix.mp4
Checklist