Open
Conversation
tallaxes
added
area/ci
3 tasks
matthchr
reviewed
Feb 4, 2026
Member
matthchr
left a comment
matthchr
left a comment
There was a problem hiding this comment.
I think using the wrong upstream-e2etest makefile cmd? We want the az variant, don't we?
| upstream-e2etests: | ||
| upstream-e2etests: tidy download | ||
| # Upstream tests are in test/suites/. Use FOCUS to filter by Describe block name. | ||
| # Available upstream tests: Chaos, Drift, Expiration, Integration, NodeClaim, StaticCapacity, Termination |
Member
There was a problem hiding this comment.
Would a link to upstream test location be better than a static list in this file?
| if [[ "$SOURCE" == 'azure' ]]; then | ||
| make e2etests | ||
| elif [[ "$SOURCE" == 'upstream' ]]; then | ||
| FOCUS="$TEST_SUITE" make upstream-e2etests |
Member
There was a problem hiding this comment.
I assume we want the same tainting... no?
Collaborator
Author
There was a problem hiding this comment.
In CI install-karpenter step does the tainting. Other steps that az-e2etests does (cleanup and untainting at the end) are only useful for development loops - though I think it won't break anything here. So Yes could make it the same, or just leave it as is - which I think is what I would prefer
| source: upstream | ||
| - name: Expiration | ||
| source: upstream | ||
| #- name: StaticCapacity |
Member
There was a problem hiding this comment.
Why comment this out?
Feels like either:
- Remove this entirely.
- Uncomment it (I assume it won't work due to fact we aren't on 1.8+ yet)
- Leave a short comment here explaining why it is commented out
matthchr
reviewed
Feb 4, 2026
Co-authored-by: Matthew Christopher <matthchr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds AWS-style
sourcefield support to e2e tests, allowing tests to run from the Azure provider, upstream karpenter-core, or both. It also removes the duplicate Chaos test suite in favor of using the upstream version.E2E Test Matrix (
e2e-matrix.yaml)nameandsourcefieldsE2E Workflow (
e2e.yaml)sourceinput parameter (azure,upstream, orall)make e2etestsfor Azure provider testsmake upstream-e2etestsfor upstream karpenter-core testssource: allMakefile
upstream-e2eteststargetFOCUSvariable to filter specific test suitesTest Cleanup
test/suites/chaos/- The Azure Chaos tests were functionally identical to upstream (same test cases, same helper functions). The upstream version works with Azure via the--default-nodeclassand--default-nodepoolflags.How was this change tested?
Does this change impact docs?
Release Note