Skip to content

Comments

chore: update sigs.k8s.io/karpenter to v1.8.2#1361

Open
tallaxes wants to merge 30 commits intomainfrom
tallaxes/karpenter-bump-1.8.x
Open

chore: update sigs.k8s.io/karpenter to v1.8.2#1361
tallaxes wants to merge 30 commits intomainfrom
tallaxes/karpenter-bump-1.8.x

Conversation

@tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Jan 21, 2026

Description

Update sigs.k8s.io/karpenter to v1.8.2, enable static capacity support

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@tallaxes tallaxes added the area/dependency Issues or PRs related to dependency changes label Jan 21, 2026
@tallaxes tallaxes self-assigned this Jan 21, 2026
@tallaxes
Copy link
Collaborator Author

Manual run of upstream StaticCapacity passed 10/12, the failures are likely due to metric-server etc. sticky overprovisioning, but have not investigated yet

$ FOCUS=StaticCapacity make az-upstream-e2etests
...
Summarizing 2 Failures:
  [FAIL] StaticCapacity Dynamic NodeClaim Interaction [It] should provision dynamic nodeclaims when static nodeclaims cant satisfy pod constraints
  /go/pkg/mod/sigs.k8s.io/karpenter@v1.8.2/test/suites/regression/staticcapacity_test.go:423
  [FAIL] StaticCapacity Edge Cases [It] should handle NodePool deletion gracefully
  /go/pkg/mod/sigs.k8s.io/karpenter@v1.8.2/test/suites/regression/staticcapacity_test.go:507

Ran 12 of 74 Specs in 3486.442 seconds
FAIL! -- 10 Passed | 2 Failed | 0 Pending | 62 Skipped

@tallaxes tallaxes added area/core Issues related with karpenter-core/upstream and removed area/dependency Issues or PRs related to dependency changes labels Jan 21, 2026
@hakman hakman mentioned this pull request Jan 21, 2026
3 tasks
Base automatically changed from tallaxes/go1.25 to main January 22, 2026 22:12
@tallaxes tallaxes marked this pull request as ready for review February 2, 2026 19:36
matthchr
matthchr previously approved these changes Feb 4, 2026
Copy link
Member

@matthchr matthchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - feel free to ping me if you push updates and need me to reapprove

@tallaxes
Copy link
Collaborator Author

tallaxes commented Feb 5, 2026

Update on testing: There are three (upstream) tests failing. Two are issues with test code (in one case it loses our NodePool labels/startupTaints causing overprovisioning, another needs a bit of timing adjustment / Eventually to work for Azure provider. The third one however appears to be a real problem: The static provisioner controller does not check if NodePool is being deleted, and can keep provisioning NodeClaims. For some reason this does not surface in AWS testing (I presume).

All of the above should be fixed by kubernetes-sigs/karpenter#2840; we should hold this until fixes land.

@tallaxes
Copy link
Collaborator Author

tallaxes commented Feb 7, 2026

Temp point to fork for validation. All three previously-failing StaticCapacity tests pass with the tallaxes/karpenter-core fork (branch tallaxes/staticcapacity-fix-v1.8.2). The fork's fixes (DeletionTimestamp check in controller.go, preserving labels/startupTaints from provider NodePool, and Eventually() wrapper in the test) are validated end-to-end against the AKS cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related with karpenter-core/upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants