Skip to content

fix: recompute debug inline positions when editor mounts during active debug #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thiagoralves merged 1 commit into from
Mar 12, 2026
Merged

fix: recompute debug inline positions when editor mounts during active debug #684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/renderer/components/_features/[workspace]/editor/monaco/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ const MonacoEditor = (props: monacoEditorProps): ReturnType<typeof PrimitiveEdit
const editorRef = useRef<null | monaco.editor.IStandaloneCodeEditor>(null)
const monacoRef = useRef<null | typeof monaco>(null)
const focusDisposables = useRef<{ onFocus?: monaco.IDisposable; onBlur?: monaco.IDisposable }>({})
const [editorMounted, setEditorMounted] = useState(false)

const {
editor,
Expand Down Expand Up @@ -356,7 +357,7 @@ const MonacoEditor = (props: monacoEditorProps): ReturnType<typeof PrimitiveEdit
}

return { prefix, positions }
}, [isDebuggerVisible, debugVarKeySet, language, name, fbInstanceContext])
}, [isDebuggerVisible, debugVarKeySet, language, name, fbInstanceContext, editorMounted])

// Phase 2: stamp current values onto cached positions (runs on each poll, O(positions) map lookups only)
useEffect(() => {
Expand Down Expand Up @@ -724,6 +725,7 @@ const MonacoEditor = (props: monacoEditorProps): ReturnType<typeof PrimitiveEdit
) {
editorRef.current = editorInstance
monacoRef.current = monacoInstance
setEditorMounted(true)

if (!editorInstance || !monacoInstance) return

Expand Down
Loading