fix: recompute debug inline positions when editor mounts during active debug#684
Conversation
…e debug When an ST tab is opened after the debugger is already running, editorRef is null during the initial debugVarPositions memo computation. Since ref changes don't trigger re-renders, the memo never recomputes and no badges appear. Add an editorMounted state flag set in handleEditorDidMount so the position-scanning memo re-runs when the editor becomes available. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Disabled knowledge base sources:
WalkthroughThis PR adds editor mount state tracking to the Monaco editor component. A new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
…e debug Cherry-pick of PR #684 (eea9b84) applied to both src_old/ and the migrated src/frontend/ copy. When an ST tab is opened after the debugger is already running, editorRef is null during the initial debugVarPositions memo computation. Adds an editorMounted state flag set in handleEditorDidMount so the position-scanning memo re-runs when the editor becomes available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary
editorRefis null during the initialdebugVarPositionsmemo computationeditorMountedstate flag set inhandleEditorDidMountso the position-scanning memo re-runs when the editor becomes availableTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit