Tools: test_new_boards.py: prevent bad lines in defaults.parm#32904
Merged
peterbarker merged 1 commit intoApr 27, 2026
Merged
Conversation
Hwurzburg
requested changes
Apr 24, 2026
where we have the ability to set a default using a define in the hwdef we should.
4261295 to
04ded18
Compare
Contributor
Author
I've added Please don't scope-creep these PRs - I think you can see yourself how you might add patterns to this, I'm just trying to get the infrastructure in place. |
Hwurzburg
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forces users to move lines which should never be in a defaults.parm into the hwdef.py
Moves this from a manual enforcement thing (@Hwurzburg !) to being a CI task.
Classification & Testing (check all that apply and add your own)
I have this branch as a pull request with some patches on top showing the test failing on a board being added with a bad defaults.parm:
Description
where we have the ability to set a default using a define in the hwdef we should.