Skip to content

Tools: test_new_boards.py: prevent bad lines in defaults.parm#32904

Merged
peterbarker merged 1 commit into
ArduPilot:masterfrom
peterbarker:pr-claude/new-boards-defaults.parm-check
Apr 27, 2026
Merged

Tools: test_new_boards.py: prevent bad lines in defaults.parm#32904
peterbarker merged 1 commit into
ArduPilot:masterfrom
peterbarker:pr-claude/new-boards-defaults.parm-check

Conversation

@peterbarker
Copy link
Copy Markdown
Contributor

Summary

Forces users to move lines which should never be in a defaults.parm into the hwdef.py

Moves this from a manual enforcement thing (@Hwurzburg !) to being a CI task.

Classification & Testing (check all that apply and add your own)

  • Checked by a human programmer
  • Non-functional change
  • No-binary change
  • Infrastructure change (e.g. unit tests, helper scripts)
  • Automated test(s) verify changes (e.g. unit test, autotest)
  • Tested manually, description below (e.g. SITL)
  • Tested on hardware
  • Logs attached
  • Logs available on request

I have this branch as a pull request with some patches on top showing the test failing on a board being added with a bad defaults.parm:

image

Description

where we have the ability to set a default using a define in the hwdef we should.

Copy link
Copy Markdown
Contributor

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BATT_x and BATTn_x params also
also NTF_LED_TYPES

where we have the ability to set a default using a define in the hwdef we should.
@peterbarker peterbarker force-pushed the pr-claude/new-boards-defaults.parm-check branch from 4261295 to 04ded18 Compare April 26, 2026 00:10
@peterbarker
Copy link
Copy Markdown
Contributor Author

BATT_x and BATTn_x params also also NTF_LED_TYPES

I've added NTF_LED_TYPES, but I don't know the correct mapping for battery parameters (and I did have a quick look at the code!)

Please don't scope-creep these PRs - I think you can see yourself how you might add patterns to this, I'm just trying to get the infrastructure in place.

@peterbarker peterbarker merged commit c9c9ff2 into ArduPilot:master Apr 27, 2026
51 checks passed
@github-project-automation github-project-automation Bot moved this from ReadyForDevCall to Done in Peter's ArduPilot 4.8 Queue Apr 27, 2026
@peterbarker peterbarker deleted the pr-claude/new-boards-defaults.parm-check branch April 29, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants