Skip to content

🔒 Security: Windows authentication with swallowed exceptions and unmanaged resource leak #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
halinhtvn3a wants to merge 1 commit into
base: master
Choose a base branch
from
Open

🔒 Security: Windows authentication with swallowed exceptions and unmanaged resource leak #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions Src/NCCommon/Util/SecurityUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,20 +31,32 @@ static extern bool LogonUser(
public static bool VerifyWindowsUserForRole(string nodeName, string userName, string password, WindowsBuiltInRole role)
{
bool isAdministrator = false;
IntPtr token;
IntPtr token = IntPtr.Zero;
try
{
LogonUser(userName, nodeName, password, 3, 0, out token);
WindowsIdentity identity = new WindowsIdentity(token);
WindowsPrincipal principal = new WindowsPrincipal(identity);
if (principal.IsInRole(role))
if (!LogonUser(userName, nodeName, password, 3, 0, out token))
{
isAdministrator = true;
return false;
}
using (WindowsIdentity identity = new WindowsIdentity(token))
{
WindowsPrincipal principal = new WindowsPrincipal(identity);
if (principal.IsInRole(role))
{
isAdministrator = true;
}
}
}
catch (Exception ex)
catch
{

return false;
}
finally
{
if (token != IntPtr.Zero)
{
Marshal.Release(token);
}
}
return isAdministrator;
}
Expand Down