🔒 Security: Windows authentication with swallowed exceptions and unmanaged resource leak#92
Open
halinhtvn3a wants to merge 1 commit intoAlachisoft:masterfrom
Conversation
…nmanaged resource leak The VerifyWindowsUserForRole method calls LogonUser (P/Invoke) but: 1. Swallows ALL exceptions in a bare catch block, hiding authentication failures and system errors. 2. Does not close the Windows token handle (IntPtr) obtained from LogonUser, causing a resource leak. 3. Does not check the return value of LogonUser; it assumes success and proceeds to use the token. Impact: Resource exhaustion over time, inability to diagnose authentication issues, and potential use of invalid token if LogonUser fails. Affected files: SecurityUtil.cs Signed-off-by: halinhtvn3a <77691576+halinhtvn3a@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The VerifyWindowsUserForRole method calls LogonUser (P/Invoke) but:
Impact: Resource exhaustion over time, inability to diagnose authentication issues, and potential use of invalid token if LogonUser fails.
Severity:
highFile:
Src/NCCommon/Util/SecurityUtil.csSolution
Replace the method with:
Changes
Src/NCCommon/Util/SecurityUtil.cs(modified)Testing