Skip to content

fix(control): decouple i2c from MIDI and fix NRPN change detection #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chmanie merged 2 commits into from
May 16, 2026
Merged

fix(control): decouple i2c from MIDI and fix NRPN change detection #520

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf0cb65
fix(control): use full 12-bit value for NRPN change detection
ArthurGibert May 13, 2026
32b7ec2
fix(control): decouple i2c send from MIDI change detection
ArthurGibert May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions faderpunk/src/apps/control.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,8 @@ pub async fn run(
let mut main_layer_value = fader.get_value();
let mut fad_val = 0;
let mut out: u16 = 0;
let mut last_out = 0;
let mut last_midi = 0u32;
let mut last_i2c = 0u16;

loop {
app.delay_millis(1).await;
Expand Down Expand Up @@ -333,11 +334,19 @@ pub async fn run(
} else {
attenuate_bipolar(main_layer_value, att_layer_value)
};
if last_out != (midi_out as u32 * 127) / 4095 {
let midi_val = if nrpn {
midi_out as u32
} else {
(midi_out as u32 * 127) / 4095
};
if last_midi != midi_val {
midi.send_cc(midi_cc, midi_out).await;
i2c.send_fader_value(0, out, range);
last_midi = midi_val;
}
if last_i2c != midi_out {
i2c.send_fader_value(0, midi_out, range);
last_i2c = midi_out;
}
last_out = (midi_out as u32 * 127) / 4095;

// Update LEDs
match latch_active_layer {
Expand Down