fix(control): decouple i2c from MIDI and fix NRPN change detection#520
Merged
Conversation
ArthurGibert
force-pushed
the
fix/control-separate-midi-i2c-thresholds
branch
from
57aba3e to
1fd0a11
Compare
chmanie
force-pushed
the
fix/control-separate-midi-i2c-thresholds
branch
2 times, most recently
from
f02a985 to
f554cfb
Compare
Previously the MIDI send threshold always used the 7-bit scaled value (midi_out * 127 / 4095), causing NRPN outputs to skip updates when the full-resolution value changed but the scaled value did not. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
i2c was only firing when the MIDI value changed, causing i2c output to be silently dropped on NRPN or range changes where MIDI didn't update. Now tracked independently with its own last_i2c threshold. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
chmanie
force-pushed
the
fix/control-separate-midi-i2c-thresholds
branch
from
f554cfb to
32b7ec2
Compare
chmanie
pushed a commit
that referenced
this pull request
May 16, 2026
…detection (#520) * fix(control): use full 12-bit value for NRPN change detection Previously the MIDI send threshold always used the 7-bit scaled value (midi_out * 127 / 4095), causing NRPN outputs to skip updates when the full-resolution value changed but the scaled value did not. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(control): decouple i2c send from MIDI change detection i2c was only firing when the MIDI value changed, causing i2c output to be silently dropped on NRPN or range changes where MIDI didn't update. Now tracked independently with its own last_i2c threshold. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary