Skip to content

Initial Song Deletion#826

Draft
imgde wants to merge 1 commit intozyrouge:mainfrom
imgde:delete-songs
Draft

Initial Song Deletion#826
imgde wants to merge 1 commit intozyrouge:mainfrom
imgde:delete-songs

Conversation

@imgde
Copy link
Copy Markdown

@imgde imgde commented May 25, 2025

This PR adds the Ability to delete Songs (from Disk permanently), but you will need to re-add your current Source Folders for writing Permissions.

Limitations/Missing/TODOs:

  • You currently can only delete one song at a time, but album/artist/etc deletion should be easy to implement
  • The deletion function has a write perm check that isn't tested and might create an Exception (might be candidate to delete)
  • I'm not 100% certain whether the RadioQueue.removeAll() logic is fine as-is -> should be re-checked
  • Some Repositories don't get updates that they would need (see TODOs in code, i personally don't mind whether the artist album count is correct after deletion, some will) -> potential for NPE's
  • Logging still in Code
  • i18n missing
  • The DeleteSongDialog has "Details" as title, as the Structure is copied from the song information dialog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant