feat: FQAN routing, entity_url exposure, and gossip signature fix#20
Open
AtmegaBuzz wants to merge 7 commits into
Open
feat: FQAN routing, entity_url exposure, and gossip signature fix#20AtmegaBuzz wants to merge 7 commits into
AtmegaBuzz wants to merge 7 commits into
Conversation
…n signature failures Old-code registries sign gossip with deprecated JSON field names (agent_id, agent_url). New-code peers can't reproduce the original signed bytes during verification, so all cross-version announcements fail with 'invalid signature'. Add Transport.SetPeerConnectCallback and Transport.BroadcastToPeer so each registry re-broadcasts its full entity list to every newly connected peer. After a node is updated and reconnects, its entities are immediately pushed with correct signatures that the peer can verify. Also log the first 120 bytes of the verification payload on signature failure to make future cross-version mismatches diagnosable from logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /v1/searchwithfqanfield now forwards to the authoritative registry if the FQAN host ≠ this registry — no gossip lookup, direct remote resolutionservice_endpointremoved from all API responses;url(public entity URL) added to search results;entity_urlnow always visible in entity list/getGET /v1/entities,GET /v1/entities/{id}, andGET /v1/entities/{id}/cardnow includefqananddeveloper_handlewhen a ZNS name is boundinvalid signature: <nil>) caused by old-code peers signing with deprecatedagent_id/agent_urlJSON field names. Fix: re-announce all local entities to every newly connected peer so the gossip index is immediatelypopulated with correctly-signed announcements after a node upgrade
total_foundhonest, exact-match bonus, score clamped to [0,1]Breaking changes
service_endpointin search resultsurlservice_endpointin entity responsesentity_urlTest plan
POST /v1/searchwithfqan: "dns01.zynd.ai/alice/url-to-text"fromzns01resolves via remote forwardGET /v1/entities/{id}returnsentity_url,fqan,developer_handlewhen boundGET /v1/entities/{id}/cardincludesfqanfieldzns01, federated text search ondns01returnszns01entities (gossip index populated on reconnect)