Add optional property for defining a custom fullscreen close button.#394
Open
thisisaaronland wants to merge 1 commit intozvonicek:masterfrom
Open
Add optional property for defining a custom fullscreen close button.#394thisisaaronland wants to merge 1 commit intozvonicek:masterfrom
thisisaaronland wants to merge 1 commit intozvonicek:masterfrom
Conversation
dogo
reviewed
Sep 7, 2020
|
|
||
| // close button configuration | ||
| closeButton.setImage(UIImage(named: "ic_cross_white", in: Bundle(for: type(of: self)), compatibleWith: nil), for: UIControlState()) | ||
| if closeButtonCustom != nil { |
Contributor
There was a problem hiding this comment.
Replace by if let avoiding the force unwrapping
Author
There was a problem hiding this comment.
Sorry for the slow reply. Just to confirm, this should be:
if let custom_button = closeButtonCustom {
closeButton = custom_button
}
Or something else?
There was a problem hiding this comment.
if let closeButtonCustom = closeButtonCustom {
closeButton = closeButtonCustom
}
This would be better to keep same names in if let and not have multiple different names
Naveen-C-Ramachandrappa
suggested changes
Jul 15, 2024
|
|
||
| // close button configuration | ||
| closeButton.setImage(UIImage(named: "ic_cross_white", in: Bundle(for: type(of: self)), compatibleWith: nil), for: UIControlState()) | ||
| if closeButtonCustom != nil { |
There was a problem hiding this comment.
if let closeButtonCustom = closeButtonCustom {
closeButton = closeButtonCustom
}
This would be better to keep same names in if let and not have multiple different names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to build on #385 but rather than defining new presets allows for a consume of the
ImageSlideshowpackage to define a customUIButtonto use for ending fullscreen mode.The button is assigned to the slideshow's
fullscreenCloseButtonproperty which is then assigned to the FullScreenSlideshowViewController'scloseButtonCustomproperty. For example: