Removing use of deprecated url.parse api in node 24#639
Open
1000TurquoisePogs wants to merge 2 commits intov3.x/stagingfrom
Open
Removing use of deprecated url.parse api in node 24#6391000TurquoisePogs wants to merge 2 commits intov3.x/stagingfrom
1000TurquoisePogs wants to merge 2 commits intov3.x/stagingfrom
Conversation
Signed-off-by: 1000TurquoisePogs <sgrady@rocketsoftware.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node is deprecating
url.parse(). i dont think they're removing it any time soon, but they say to usenew URL()instead.so, i found that in 2 places:
the GET /plugins call, (as seen when login to desktop), was using it to check for headers.
req.headersalready exists in expressjs so i dont know why we did that. i made that change.RBAC used url parsing to get part of the path.
new URL()can do the same. So, you'll need to run an RBAC test to be sure of that change.