Fixing the SAF keyring error through console logging it.#565
Fixing the SAF keyring error through console logging it.#565Atharva-Kanherkar wants to merge 2 commits intozowe:v2.x/stagingfrom
Conversation
1000TurquoisePogs
left a comment
There was a problem hiding this comment.
Disabling an error to work-around a bug is not a solution to a bug.
Identify why the bug has happened and resolve that.
If this PR is based on an outdated copy of v2.x/staging, you may have missed that this was already fixed.
There was a bug in which saf was changed from being initialized to undefined to instead be initialized to an empty array.
Previously if (saf) was done, which was previously false but then true when set to an empty array.
A fix was done to do if (saf.length > 0 instead.
This fix was made to v2.x/rc branch but not v2.x/staging branch.
Therefore the bug still existed in v2.x/staging branch.
But, the two branches were synchronized a week or two ago so you should check if the problem that you still have exists. You may not need a PR at all.
Proposed changes
The SAF keyring error was an error which did not allow the server to start without an error, until we could find the fix, we have decided to bypass it and know the error through console logging,
Type of change
Please delete options that are not relevant.
PR Checklist