Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the option
app.gracefulTimeoutto decide many seconds a graceful shutdown is allowed to take - which is - how long docker should wait from callingdocker stop(which triggersSIGINT) to callingdocker rm -f(which triggersSIGTERM).I don't know at which place the documentation can be updated, so I've left this task open.
The default value of
app.gracefulTimeoutis10and is in seconds.As of how I see it, the other containers don't need a graceful shutdown, or do they? If yes, we need to take into account that e.g. nginx uses a different signal for a graceful shutdown than
SIGINT- this just as a small note in case it's required.This is untested though ...